1725896 - New chat message now white on white in dark mode (starting 92b1.)

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Ari Maniatis]

Attachment: Screen Shot 2021-08-16 at 10.21.04am.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

1. Upgrade to Thunderbird 92b1. The problem did not happen in 91 betas.
2. Use dark mode on OSX
3. Have theme set up with white text on black background for writing new emails

Actual results:

Chat window is now white text on white backgrounnd. Note the screen shot here shows some text highlighted. Without the highlight it is completely invisible.

Expected results:

Either black text on white or use same settings as new email window which gives me white text on black.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1725896-chat-variable-clean-up.patch

This is also a fallout from bug 1698814. I used the bug also to unify the code for the box and use the Proton styling for focus and error.

I could also provide a patch for ESR 91 without the variable change.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9236479 [details] [diff] [review]
1725896-chat-variable-clean-up.patch

Review of attachment 9236479 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/im/themes/chat.css
@@ +502,5 @@
>  }
>  
> +.conv-textbox:focus-visible {
> +  border-color: var(--toolbar-field-focus-border-color);
> +  outline: 1px solid var(--toolbar-field-focus-border-color);

This double border + outline doesn't work well with 4k monitors and scaled up text.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1725896-chat-variable-clean-up.patch

Now with a 2px border instead of 1px border and 1px outline.

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9236492 [details] [diff] [review]
1725896-chat-variable-clean-up.patch

Review of attachment 9236492 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 5

[Alessandro Castellani [:aleca]]

I could also provide a patch for ESR 91 without the variable change.

Yes, if the focus styling is wrong in 91 we could have a dedicated patch to uplift without the variable change.
ore of a visual enhancement than a defect at that point, but I don't think it would be a problem unless we want to be conservative with our uplifts.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5a67e5e08877
Port bug 1698814 (Clean up --lwt-toolbar-field-* variables after proton) also to chat. r=aleca

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 9236492 [details] [diff] [review]
1725896-chat-variable-clean-up.patch

[Approval Request Comment]
User impact if declined: with dark theme no contrast on chat input box and no Proton focus styling
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Richard Marti (:Paenglab)]

Attachment: 1725896-chat-focus-ESR.patch

[Approval Request Comment]
User impact if declined: chat input box doesn't have the Proton focus styling
Testing completed (on c-c, etc.): on c-c (with additional variable renaming)
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9236492 [details] [diff] [review]
1725896-chat-variable-clean-up.patch

[Triage Comment]
Approved for beta

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9236656 [details] [diff] [review]
1725896-chat-focus-ESR.patch

[Triage Comment]
Approved for esr91, even though it hasn't been through beta, because chat is unusable in dark mode, and should only affect those users (rjl agrees)

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 91.0.2:
https://hg.mozilla.org/releases/comm-esr91/rev/903c1ae4571c

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 92.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/8e8bdb109237