1725950 - The "Empty" bookmark folder label is no longer greyed out in the Bookmarks Toolbar and in the Other Bookmarks

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Simona Badau, Desktop QA]

[Environment:]

Mac 10.15
Ubuntu 20.04
Windows 10 x64

Firefox 92 beta 4
Nightly 93.0a1

[Steps:]

1. Open Firefox.
2. Open the Library window and create a new folder for each of the locations: Bookmarks Toolbar, Bookmarks menu, Other Bookmarks - leave it empty
3. Open Application Menu -> More Tools ->Customize toolbar...-> place the Bookmarks menu near the URL Bar.
4. Go to each of the newly created folders, click on them and observe the "Empty" bookmark folder label.

[Actual Result:]

The "Empty" bookmark folder label is only greyed out in the Bookmarks Menu.

[Expected Result:]

The "Empty" bookmark folder label should be greyed out in the Bookmarks Menu, Bookmarks Toolbar, and Other Bookmarks.

[Notes:]

This issue is not reproducible on Firefox 91.

Found commit message:
Bug 1703051, apply proton panel styling to other bookmarks dropdown and overflow menu in bookmarks toolbar r=desktop-theme-reviewers,mconley,jaws,harry
pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1e8ff38398ac6a98d0a0b5668a598206ed084688&tochange=9e5ec8c60805229571fb0b1a2b59f1fc53100cf2

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1725950 - use panel disabled color for disabled bookmark '(empty)' items, r?emalysz

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e2ba0c4c187
use panel disabled color for disabled bookmark '(empty)' items, r=emalysz

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4e2ba0c4c187

Comment 4

[:Gijs (he/him)]

Comment on attachment 9236673 [details]
Bug 1725950 - use panel disabled color for disabled bookmark '(empty)' items, r?emalysz

Beta/Release Uplift Approval Request

• User impact if declined: Confusing UI for empty folders, as the item looks like it can be used but is not in fact usable
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: N/A
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Single added CSS rule
• String changes made/needed: No

Comment 5

[Simona Badau, Desktop QA]

Verified as fixed using the latest Nightly 93.0a1 on Windows 10 x64, Ubuntu 20.04, and macOS Big Sur 11.5.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9236673 [details]
Bug 1725950 - use panel disabled color for disabled bookmark '(empty)' items, r?emalysz

Approved for 92.0b6.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b82ffa25b838

Comment 8

[Simona Badau, Desktop QA]

Verified as fixed on the latest Firefox 92 beta 6 - verified on macOS Big Sur 11.5, Ubuntu 20.04, and Windows 10 x64.