1725952 - Upgrade to ESLint v8.x

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

https://github.com/eslint/eslint/blob/master/docs/user-guide/migrating-to-8.0.0.md

Although the actual release is still in beta stage, the migration guide is now published. Probably a good chance to deal with breaking changes.

This release adds Top Level Await support and thus should allow:

<script type=module>
SimpleTest.waitForExplicitFinish();
await SimpleTest.promiseFocus(); // Currently ESLint v7 blocks this
</script>

Comment 1

[Mark Banner (:standard8)]

Bug 1725934 is going to update Babel which will give us top level await support.

We do want to upgrade to ESLint 8 once it is ready. So I took a look at the current version and there's currently a couple of blockers:

• eslint-plugin-import breaks with eslint v8. They have work in progress to help fix it.
• The ESLint rule no-loss-of-precision is enabled by default in v8. There's a few cases where we fail, so we could fix those ahead of time as the rule is in the current ESLint versions.
• There's a few cases where the new treatment of directives for in-line comments causes ESLint failures - namely where a comment line starts with "global".

Comment 2

[Takanori MATSUURA]

v8.1.0 has been released.

Comment 3

[Mark Banner (:standard8)]

At the moment there's no rush to update, in particular, Atom's linter-eslint is broken:

https://github.com/AtomLinter/linter-eslint/issues/1440

We also need updates from dependencies:

https://github.com/yannickcr/eslint-plugin-react/pull/3059
https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/issues/809
https://github.com/mozilla/eslint-plugin-no-unsanitized (I'm told it will be worked on soon)
https://github.com/babel/babel/issues/13712 (not sure if needed or not)

Comment 4

[Mark Banner (:standard8)]

I think most of the blockers here have now been resolved, adding to my list to look at soon.

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1725952 - Drop .xul file support for eslint-plugin-mozilla. r?Mardak

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1725952 - Upgrade ESLint to v8.x. r?Mardak

Depends on D144001

Comment 7

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=250719e5083d84ac65463b006d80e49e96d4571c

Comment 8

[Mark Banner (:standard8)]

Updated try push: https://treeherder.mozilla.org/jobs?repo=try&revision=7b6d6b6f81b526c585d58b5c2cf7ea292dde2453

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7e2ecdf4126
Drop .xul file support for eslint-plugin-mozilla. r=Mardak
https://hg.mozilla.org/integration/autoland/rev/adef1e773e19
Upgrade ESLint to v8.x. r=Mardak

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c7e2ecdf4126
https://hg.mozilla.org/mozilla-central/rev/adef1e773e19