1725934 - Unnecessary Babel plugin for linting

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Nicolò Ribaudo]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.212 Safari/537.36

Steps to reproduce:

The .babel-eslint.rc.js [1] config file in mozilla-central enables the @babel/plugin-syntax-class-properties plugin, but it's not necessary since class fields are enabled by default starting from Babel 7.14.0 [2] and mozilla-central is using @babel/core@7.14.3 [3].

[1] https://searchfox.org/mozilla-central/rev/d3683dbb252506400c71256ef3994cdbdfb71ada/.babel-eslint.rc.js#7
[2] https://babeljs.io/blog/2021/04/29/7.14.0#new-class-features-enabled-by-default
[3] https://searchfox.org/mozilla-central/rev/d3683dbb252506400c71256ef3994cdbdfb71ada/package.json#7

Comment 1

[Nicolò Ribaudo]

I was going to submit a patch, but then noticed this comment by Mark Banner (:standard8) so I don't think I can.

Comment 2

[Mark Banner (:standard8)]

(In reply to Nicolò Ribaudo from comment #1)

I was going to submit a patch, but then noticed this comment by Mark Banner (:standard8) so I don't think I can.

Thank you for filing this. It is indeed unfortunate that we only have a few people that can update this at the moment - Although some of the work could be done by others (checking for new errors, etc), the new packages have to be uploaded to the build infrastructure which also regenerates package-lock.json. Overall, that generally means for small changes like this it isn't worth the extra time for a contributor to do.

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1725934 - Remove unnecessary babel plugin, and update node modules to the latest versions. r?Mardak!

plugin-syntax-class-properties was supported by default in Babel 7.14.0.
This also adds top level await support in modules with the upgrade to Babel 7.15.0.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/306b43a4a5bd
Remove unnecessary babel plugin, and update node modules to the latest versions. r=Mardak

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/306b43a4a5bd