1726096 - event dialog too small and doesn't remember size

Status: VERIFIED FIXED

(Calendar :: Dialogs, enhancement)

Description

[S.Brooks]

Attachment: 20210817_160757.jpg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

Event dialog does not remember size and default opening size is too small to show a meaningful amount of the description particularly when attendees and the new "you have accepted this invitation" notification is displayed. This means that every time the dialog is opened it requires the user to resize it to see enough of the description

Actual results:

open a calendar event as a dialog not a tab. resize and close. Open again and its back at the default size.

Expected results:

The dialog box should remember its size (at the very least the vertical dimension) so that the user can set it to display more of the description and not have to resize it every time.

Comment 1

[S.Brooks]

Attachment: Screenshot 2021-08-17 165152.png

Comment 2

[S.Brooks]

Comment on attachment 9236574 [details]
20210817_160757.jpg

admin delete please

Comment 3

[David Lawrence [:dkl]]

The content of attachment 9236577 [details] has been deleted for the following reason:

Deleted at request of author

Comment 4

[David Lawrence [:dkl]]

The content of attachment 9236574 [details] has been deleted for the following reason:

Deleted at request of author

Comment 5

[S.Brooks]

Attachment: Event dialog description shows too few lines.

Comment 6

[Geoff Lankow (:darktrojan)]

I agree, this is annoying. There's multiple problems here, but the main cause is that the item description is loaded in a separate frame and the outer window has no idea how big it is.

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1726096 - Resize calendar item description iframe to match contents. r=mkmelin

Depends on D127599

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/859f0adb7de7
Resize calendar item description iframe to match contents. r=mkmelin

Comment 9

[Geoff Lankow (:darktrojan)]

Comment on attachment 9244443 [details]
Bug 1726096 - Resize calendar item description iframe to match contents. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1607834
User impact if declined: event summary dialog is sized badly, user has to scroll to see all of a description
Testing completed (on c-c, etc.): in 94
Risk to taking this patch (and alternatives if risky): none

Comment 10

[Geoff Lankow (:darktrojan)]

Comment on attachment 9244443 [details]
Bug 1726096 - Resize calendar item description iframe to match contents. r=mkmelin

Oops, wrong flag.

[Approval Request Comment]
Regression caused by (bug #): bug 1607834
User impact if declined: event summary dialog is sized badly, user has to scroll to see all of a description
Testing completed (on c-c, etc.): landed a week ago
Risk to taking this patch (and alternatives if risky): none

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9244443 [details]
Bug 1726096 - Resize calendar item description iframe to match contents. r=mkmelin

[Triage Comment]
Approved for beta

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 94.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/dd9d485c0367

Comment 13

[Geoff Lankow (:darktrojan)]

Comment on attachment 9244443 [details]
Bug 1726096 - Resize calendar item description iframe to match contents. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1607834
User impact if declined: event summary dialog is sized badly, user has to scroll to see all of a description
Testing completed (on c-c, etc.): in 94b3
Risk to taking this patch (and alternatives if risky): none

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9244443 [details]
Bug 1726096 - Resize calendar item description iframe to match contents. r=mkmelin

[Triage Comment]
Approved for esr91

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 91.3.0:
https://hg.mozilla.org/releases/comm-esr91/rev/8927c61422b9

Comment 16

[WaltS48 [:walts48]]

Verified testing the 91.3.0 release candidate on Windows 10.

Comment 17

[S.Brooks]

This behaviour has resurfaced (regression) in Supernova 115.3.0 (64-bit).

The default size that a meeting event opens in Supernova 115.3.0 only contains 2-3 lines of the description and in the case of MS TEAMS meetings requires the dialog to be resized every time in order to see any useful information.

I have added a new screenshot to show

Comment 18

[S.Brooks]

Attachment: Supernova EVENT dialog too small

Comment 19

[Magnus Melin [:mkmelin]]

-> bug 1854137