1728276 - Import Event dialog doesn't show descriptions anymore

Status: VERIFIED FIXED

(Calendar :: Dialogs, defect)

Description

[Magnus Melin [:mkmelin]]

Events & Tasks | Import ...
Select an .ics, the preview dialog will show.

The description of the events in the ics do not show. They should. This regressed by bug 1607834.

Comment 1

[Geoff Lankow (:darktrojan)]

It appears that the descriptions are loaded, and then replaced by about:blank. That's not helpful.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1728276 - Wait for iframe to load before adding calendar item description to it. r=mkmelin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3786b34e2f7c
Wait for iframe to load before adding calendar item description to it. r=mkmelin

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9244441 [details]
Bug 1728276 - Wait for iframe to load before adding calendar item description to it. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: imported events preview no longer has descriptions
Testing completed (on c-c, etc.): in 94
Risk to taking this patch (and alternatives if risky): small

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9244441 [details]
Bug 1728276 - Wait for iframe to load before adding calendar item description to it. r=mkmelin

Oops, wrong flag.

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: imported events preview no longer has descriptions
Testing completed (on c-c, etc.): landed a week ago
Risk to taking this patch (and alternatives if risky): small

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9244441 [details]
Bug 1728276 - Wait for iframe to load before adding calendar item description to it. r=mkmelin

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 94.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/7922bfa4c0da

Comment 8

[WaltS48 [:walts48]]

Verified with an old exported .ics file with Descriptions using Thunderbird 94.0b3 on Windows 10

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 9244441 [details]
Bug 1728276 - Wait for iframe to load before adding calendar item description to it. r=mkmelin

[Approval Request Comment]
This is needed on 91 as well.

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9244441 [details]
Bug 1728276 - Wait for iframe to load before adding calendar item description to it. r=mkmelin

[Triage Comment]
Approved for esr91

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 91.3.0:
https://hg.mozilla.org/releases/comm-esr91/rev/c1a1fa1f1347