1726172 - Trademark in about dialog not readable with dark theme

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

I saw in beta that the trademark text isn't readable with dark theme.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1726172-aboutDialog-trademark.patch

I should have set the colour on aboutDialogContainer instead only on the clientBox. With this the trademark gets the correct colour. On Daily is no trademark and this is only on beta visible.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9236651 [details] [diff] [review]
1726172-aboutDialog-trademark.patch

Review of attachment 9236651 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for taking care of this.
Maybe let's update the commit message with: "[Dark Mode] Fix the trademark color contrast in the About dialog".

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1726172-aboutDialog-trademark.patch

Updated the commit message.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/721b5d2c8b06
[Dark Mode] Fix the trademark color contrast in the About dialog. r=aleca

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9236684 [details] [diff] [review]
1726172-aboutDialog-trademark.patch

[Approval Request Comment]
User impact if declined: With dark theme unreadable trademark text in about dialog
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9236684 [details] [diff] [review]
1726172-aboutDialog-trademark.patch

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 92.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/80c9ace3664d

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9236684 [details] [diff] [review]
1726172-aboutDialog-trademark.patch

[Triage Comment]
Approved for esr91

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 91.0.3:
https://hg.mozilla.org/releases/comm-esr91/rev/7f37735b4076