Closed Bug 1726208 Opened 4 years ago Closed 4 years ago

[Dark theme] text fields shouldn't have a faint blue tint background

Categories

(Thunderbird :: Theme, task)

Product:
Thunderbird
Component:
Theme
Type:
task

Tracking

(thunderbird_esr91+ fixed, thunderbird92+ fixed, thunderbird93 affected)

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
thunderbird_esr91 + fixed
thunderbird92 + fixed
thunderbird93 --- affected

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 2 obsolete files)

1726208-textfield-background-color.patch
1.58 KB, patch
aleca
: review+
wsmwk
: approval-comm-beta+
wsmwk
: approval-comm-esr91+
Details | Diff | Splinter Review
No description provided.

How about this colour? I also changed the popup background colour which used the same colour.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9236695 - Flags: review?(alessandro)

I missed one colour.

Attachment #9236695 - Attachment is obsolete: true
Attachment #9236695 - Flags: review?(alessandro)
Attachment #9236804 - Flags: review?(alessandro)
Comment on attachment 9236804 [details] [diff] [review] 1726208-textfield-background-color.patch Review of attachment 9236804 [details] [diff] [review]: ----------------------------------------------------------------- The textfield color is perfect. The popup bg color is a bit too light and in some context it blends too much with the background. We should try a darker color like `rgb(35, 35, 36)`
Attachment #9236804 - Flags: review?(alessandro) → feedback+

Using rgb(40, 40, 41).

Attachment #9236804 - Attachment is obsolete: true
Attachment #9236862 - Flags: review?(alessandro)
Comment on attachment 9236862 [details] [diff] [review] 1726208-textfield-background-color.patch Review of attachment 9236862 [details] [diff] [review]: ----------------------------------------------------------------- Looks great now, thanks.
Attachment #9236862 - Flags: review?(alessandro) → review+
status-thunderbird92: --- → affected
status-thunderbird93: --- → affected
status-thunderbird_esr91: --- → affected
tracking-thunderbird92: --- → ?
tracking-thunderbird_esr91: --- → ?
Keywords: checkin-needed-tb
Target Milestone: --- → 93 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/00de3b18bbe1
[Dark theme] Change the textfield and popup to a less blueish color. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED

Uplift requests?

Flags: needinfo?(richard.marti)

First we need Daily builds to test it.

Flags: needinfo?(richard.marti)

Comment on attachment 9236862 [details] [diff] [review]
1726208-textfield-background-color.patch

[Approval Request Comment]
User impact if declined: Not so good fitting colour in text fields and popups
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low, only colour changes.

Attachment #9236862 - Flags: approval-comm-esr91?
Attachment #9236862 - Flags: approval-comm-beta?

Comment on attachment 9236862 [details] [diff] [review]
1726208-textfield-background-color.patch

[Triage Comment]
Approved for beta

Attachment #9236862 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9236862 [details] [diff] [review]
1726208-textfield-background-color.patch

[Triage Comment]
Approved for esr91

Attachment #9236862 - Flags: approval-comm-esr91? → approval-comm-esr91+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: