Closed
Bug 1726373
Opened 3 years ago
Closed 3 years ago
Fail the build when Cargo.lock is modified
Categories
(Firefox Build System :: General, task)
Firefox Build System
General
Tracking
(firefox93 fixed)
RESOLVED
FIXED
93 Branch
| Tracking | Status | |
|---|---|---|
| firefox93 | --- | fixed |
People
(Reporter: kvark, Assigned: glandium)
Details
Attachments
(1 file)
I just got a large change backed out because Cargo lock needed to be updated - https://bugzilla.mozilla.org/show_bug.cgi?id=1622846#c63
It would be very useful if ./mach try auto included this failing job "Linux opt - TL32(gd)" automatically if it sees any lockfile changes.
|
Assignee | |
Comment 1•3 years ago
|
||
Better yet, we should just make every build fail.
Assignee: nobody → mh+mozilla
Summary: Automatically check for frozen Cargo.lock if it's modified → Fail the build when Cargo.lock is modified
|
|
Assignee | |
Updated•3 years ago
|
Component: Task Configuration → General
|
|
Assignee | |
Comment 2•3 years ago
|
||
What currently happens when Cargo.lock doesn't match is that the first
time we run cargo to generate the cbindgen metadata, we don't run it
with --frozen (unlike subsequent calls), and that locally fixes
Cargo.lock. Instead of that, we make the build fail, which will prevent
out-of-sync Cargo.lock from slipping in the tree in the first place.
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/78cb22885046 Fail the build when Cargo.lock is modified. r=firefox-build-system-reviewers,mhentges
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox93:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•