1726378 - Debugger keyboard shortcuts for prev/next in search bar are not discoverable

Status: RESOLVED DUPLICATE of bug 1746149

(DevTools :: Debugger, defect, P3)

Description

[Julian Descottes [:jdescottes]]

STRs:

• open a source in the debugger
• search some text with several hits in the source
• try to go to the next occurrence with the keyboard

The "search.again"and "search.againPrev" key shortcuts are using the macos-only meta "Cmd", so they can't be used on windows or linux.

https://searchfox.org/mozilla-central/rev/d3683dbb252506400c71256ef3994cdbdfb71ada/devtools/client/locales/en-US/debugger.properties#284-294

sourceSearch.search.again.key3=Cmd+G
sourceSearch.search.againPrev.key3=Cmd+Shift+G

This regressed when the shortcuts were updated in Bug 1488662. However fixing this would now conflict with another shortcut gotoLineModal which uses Ctrl+G. The original issue fixed by Bug 1488662 was that gotoLineModal was already using a shortcut for another feature.

But it seems that search.again and search.againPrev are redundant with "Enter" and "shift+Enter". Those shortcuts are not in the localization file, their behavior seems hardcoded at https://searchfox.org/mozilla-central/rev/d3683dbb252506400c71256ef3994cdbdfb71ada/devtools/client/debugger/src/components/Editor/SearchBar.js#179

I would suggest:

• remove the macos only shortcuts sourceSearch.search.again.key3 & sourceSearch.search.againPrev.key3
• show Enter & Shift+Enter in tooltips for the prev/next button of the debugger search bar

Comment 1

[Marco Castelluccio [:marco]]

Set release status flags based on info from the regressing bug 1488662