1488662 - same keyboard shortcut (⌘;) is used for two functions: "step in" and "go to line"

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[:glob ✱]

same keyboard shortcut (⌘;) is used for two functions: "step in" and "go to line".

steps to reproduce:
1. set a breakpoint and hit the breakpoint with the debugger
2. press ⌘; to step into a function

expected:
- step-in action performed
- nothing else

actual:
- step-in action performed
- the "search sources" popup is shown, with ":" populated as the query string; ie. the "go to line" feature


note the ⌘; and ⌘' shortcuts are quite useful on macos, where F11 is mapped to "show desktop" by default.

Comment 1

[Julian Descottes [:jdescottes]]

Looks like a debugger frontend issue, ported to https://github.com/devtools-html/debugger.html/issues/6946

Comment 2

[Chujun Lu]

Hi, I'm interested in working on it. Can I give it a try?

Comment 3

[David Walsh :davidwalsh]

I'd love for you to look at it Chujun! :)

Comment 4

[Chujun Lu]

Attachment: Bug 1488662 Change go to line shortcut to Ctrl+G r=Derek

The current “go to line” shortcut CmdOrCtrl+; conflicts with the “step in” shortcut. It is
replaced to use the same as Chrome debugger and Sublime Text's shortcut: Ctrl+G. Upper or lower cases don’t matter.

1. Current behavior:
   1a) With no file open in editor:
   Hitting Cmd+; or Cmd+Shift+; opens the “go to line” search bar.

1b) With a file open in editor, but not pausing in debugger:
Hitting Cmd+; or Cmd+Shift+; opens the “go to line” search bar.

1c) Pause in debugger:
Hitting Cmd+; runs step in and also opens the “go to line” search bar;
Hitting Cmd+Shift+; runs step over and also opens the “go to line” search bar;

2. Code changes:
   2a) Create gotoLineModal.key3.
   2b) Update localization note.
   2b) Update snapshot test.

3. With code changes, in both Mozilla Central Firefox build and Debugger launchpad
   3a) With no file open in editor:
   Hitting Ctrl+G opens the “go to line” search bar. No sure if this is ideal.

3b) With a file open, but not pausing in debugger:
Hitting Ctrl+Gopens the “go to line” search bar; hitting Ctrl+G again or escape closes the bar.

3c) Pause in debugger:
Hitting Cmd+; or Cmd+Shift+; doesn’t open the “go to line” search bar.
Hitting Ctrl+G opens the “go to line” search bar.
Type in a valid number, hit enter. The editor window goes to the destination line.
If you don’t type anything, hit escape, or hit Ctrl+G again, the “go to line” search bar closes.

Comment 5

[Jason Laster [:jlast]]

David, could you help review this?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/812f70d7ccae
Change go to line shortcut to Ctrl+G r=davidwalsh

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/812f70d7ccae