same keyboard shortcut (⌘;) is used for two functions: "step in" and "go to line"

RESOLVED FIXED in Firefox 69

Status

defect
P3
normal
RESOLVED FIXED
11 months ago
5 days ago

People

(Reporter: glob, Assigned: chujunlu)

Tracking

(Blocks 3 bugs)

unspecified
Firefox 69
Dependency tree / graph

Firefox Tracking Flags

(firefox69 fixed)

Details

Attachments

(1 attachment)

same keyboard shortcut (⌘;) is used for two functions: "step in" and "go to line".

steps to reproduce:
1. set a breakpoint and hit the breakpoint with the debugger
2. press ⌘; to step into a function

expected:
- step-in action performed
- nothing else

actual:
- step-in action performed
- the "search sources" popup is shown, with ":" populated as the query string; ie. the "go to line" feature


note the ⌘; and ⌘' shortcuts are quite useful on macos, where F11 is mapped to "show desktop" by default.
Looks like a debugger frontend issue, ported to https://github.com/devtools-html/debugger.html/issues/6946
Priority: -- → P3

Hi, I'm interested in working on it. Can I give it a try?

I'd love for you to look at it Chujun! :)

The current “go to line” shortcut CmdOrCtrl+; conflicts with the “step in” shortcut. It is
replaced to use the same as Chrome debugger and Sublime Text's shortcut: Ctrl+G. Upper or lower cases don’t matter.

  1. Current behavior:
    1a) With no file open in editor:
    Hitting Cmd+; or Cmd+Shift+; opens the “go to line” search bar.

1b) With a file open in editor, but not pausing in debugger:
Hitting Cmd+; or Cmd+Shift+; opens the “go to line” search bar.

1c) Pause in debugger:
Hitting Cmd+; runs step in and also opens the “go to line” search bar;
Hitting Cmd+Shift+; runs step over and also opens the “go to line” search bar;

  1. Code changes:
    2a) Create gotoLineModal.key3.
    2b) Update localization note.
    2b) Update snapshot test.

  2. With code changes, in both Mozilla Central Firefox build and Debugger launchpad
    3a) With no file open in editor:
    Hitting Ctrl+G opens the “go to line” search bar. No sure if this is ideal.

3b) With a file open, but not pausing in debugger:
Hitting Ctrl+Gopens the “go to line” search bar; hitting Ctrl+G again or escape closes the bar.

3c) Pause in debugger:
Hitting Cmd+; or Cmd+Shift+; doesn’t open the “go to line” search bar.
Hitting Ctrl+G opens the “go to line” search bar.
Type in a valid number, hit enter. The editor window goes to the destination line.
If you don’t type anything, hit escape, or hit Ctrl+G again, the “go to line” search bar closes.

David, could you help review this?

Flags: needinfo?(dwalsh)
Flags: needinfo?(dwalsh)
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/812f70d7ccae
Change go to line shortcut to Ctrl+G r=davidwalsh
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
Assignee: nobody → chujunlu
Blocks: 1565711
Blocks: 1565713
You need to log in before you can comment on or make changes to this bug.