1726429 - Download activity uses the wrong numbers for its progress bar

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Henry Wilkes (they/them) [:henry-x]]

From https://phabricator.services.mozilla.com/D119289#inline-674154

The following line is using the wrong numbers

https://searchfox.org/comm-central/rev/bdf1197238d795a88782e8ef8bf12facc7560247/mail/components/activity/modules/autosync.jsm#352

The msg message string uses syncItem.totalDownloaded / syncItem.pendingMsgCount, whilst the progress bar uses numOfMessages / totalPending.

pendingMsgCount is whatever the maximum value of totalPending has been (line 321), but numOfMessages is how much we just added to the totalDownload (line 333), so will usually be less and is the wrong value to use for a percentage.

Comment 1

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1726429 - Use correct numbers for download activity progress. r=darktrojan

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b2bfce0407ce
Use correct numbers for download activity progress. r=darktrojan