1726525 - Incorrect menu bar colors when mousing over menu bar in "High Contrast Black" Windows color scheme

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[David Ogilvie]

Attachment: tb screenshot compose menu.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

1. Set Windows color scheme to "High Contrast Black" (Windows+I > Ease of Access > High Contrast > Select Color Scheme" > "High Contrast Black". Use left_alt + left_shift + PrtScr to toggle.
2. Start TB Daily 2021-08-19.
3. Move mouse over menu bar.

Actual results:

When mouse moves over menu bar, menu item shows white text on a white background. If you are in the compose window, moving the mouse over the menu bar produces black text on a black background. (See attached screen shots.)

Expected results:

Menus should show up as black text on white when the mouse moves over the menu item.

This problem does not occur in Firefox Nightly.

Comment 1

[David Ogilvie]

Attachment: tb screenshot all unread.png

Comment 2

[David Ogilvie]

Attachment: tb screenshot all unread no border.png

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1726525-menu-rules.patch

In primaryToolbar.css we repeat to use the same rule for different Windows versions. And this applies only to the main window. We need to simplify this and move to messenger.css to apply to AB and Composer too.

This rule has to apply to all non-default themes and also to Windows 10.

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9237529 [details] [diff] [review]
1726525-menu-rules.patch

Review of attachment 9237529 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6c4039e0af4f
Move the #mail-menubar > menu rule to messenger.css to apply on AB and composer too. r=aleca

Comment 6

[David Ogilvie]

This problem also occurs when you mouse over the "all/unread" control. The control also needs to have a border arpimd the drop-down box as it doesn't look right without one. (See attached file.)

Comment 7

[David Ogilvie]

Looks good now! Thanks for tracking it down so quickly! :)

Comment 8

[Richard Marti (:Paenglab)]

(In reply to David Ogilvie from comment #6)

The control also needs to have a border arpimd the drop-down box as it doesn't look right without one. (See attached file.)

Please, can you file a new bug for this issue? What colour should the border get, like the text or a bit fainted?

Comment 9

[Richard Marti (:Paenglab)]

Comment on attachment 9237529 [details] [diff] [review]
1726525-menu-rules.patch

[Approval Request Comment]
User impact if declined: on Windows HCT low contrast when hovering menu
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9237529 [details] [diff] [review]
1726525-menu-rules.patch

[Triage Comment]
Approved for beta

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 92.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/94eb8404dd1a

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9237529 [details] [diff] [review]
1726525-menu-rules.patch

[Triage Comment]
Approved for esr91

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 91.1.0:
https://hg.mozilla.org/releases/comm-esr91/rev/0a14e51a28e2