1726659 - Prevent update UI on a Silent Restart

Status: RESOLVED FIXED

(Toolkit :: Application Update, task, P1)

Description

[Robin Steuber (she/her) [:bytesized]]

Bug 1726239 adds Silent Restart (restart with opening any windows) functionality to Firefox in order to facilitate a no-window restart to apply updates (Bug 1720742).

When we restart this way, we should not show any user interface during the update. This will be quite similar to the existing feature where the updater doesn't display any UI when the callback is a background task.

Comment 1

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1726659 - Rename sCallbackIsBackgroundTask to sUpdateSilently r=agashlin

Another patch on this stack will change the functionality of sCallbackIsBackgroundTask and IsCallbackBackgroundTask so that they also apply to when we do a silent restart (see Bug 1726239). This makes their names less applicable to how they will function going forward. The renaming will be consolidated to this patch to make the other one easier to read.

This also renames BACKGROUND_TASK_NEEDED_ELEVATION_ERROR, since we will want to use that same error code when a macOS update needs an elevation dialog.

Comment 2

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1726659 - Prevent update UI on a Silent Restart r=agashlin

Depends on D123567

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/454a24d81e37
Rename sCallbackIsBackgroundTask to sUpdateSilently r=agashlin
https://hg.mozilla.org/integration/autoland/rev/57e5e1acf971
Prevent update UI on a Silent Restart r=agashlin

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/454a24d81e37
https://hg.mozilla.org/mozilla-central/rev/57e5e1acf971