1699545 - Updater shouldn't call InitProgressUI during a silent update

Status: RESOLVED FIXED

(Toolkit :: Application Update, task, P1)

Comment 1

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

We need to look into whether the elevation mechanism for updates on macOS (ServeElevatedUpdate and so on) would prompt for elevation from a background task, and if so prevent that from happening.

(Oops, pressed enter while typing the summary.)

Comment 2

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

We should also block InitProgressUI here, which doesn't do anything on Windows but does on Mac (and GTK). It might not be visible but we shouldn't be initing the UI if it isn't going to be used.

Comment 3

[Robin Steuber (she/her) [:bytesized]]

I was about to mark this as a duplicate of Bug 1726659, but actually, I think I missed the InitProgressUI() call mentioned above. So I think I'll keep this open specifically to fix that.

Comment 4

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1699545 - Updater shouldn't call InitProgressUI during a silent update r=agashlin!

Comment 5

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1699545 - Updater shouldn't call InitProgressUI during a silent update r=agashlin!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87d6970d5d19
Updater shouldn't call InitProgressUI during a silent update r=agashlin

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/87d6970d5d19