1726800 - Finalize ModuleRegistry implementation

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Julian Descottes [:jdescottes]]

We introduced a simple ModuleRegistry in https://bugzilla.mozilla.org/show_bug.cgi?id=1694144 in order to reference all existing modules and avoid test failures from browser/base/content/test/static/browser_all_files_referenced.js

But in the long run, we would like ModuleRegistry to have more responsibilities:

• check if a given module has an implementation for a given context+destination
• check list of commands supported by a module
• check list of events supported by a module

The goal of this bug is to improve the current ModuleRegistry to match the description above. This should make error reporting easier, so this blocks Bug 1724411.

It will probably also make Bug 1723592 redundant.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1726800 - [remote] Verify commands as early as possible in MessageHandler

The ModuleRegistry can now be used to import BiDi modules.
The ModuleCache can be queried to get all the relevant modules for a moduleName+destination pair.
Error messages have been improved and are verified with a dedicated test

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1726800 - [remote] Serialize and deserialize command errors in MessageHandlerFrame actors

Depends on D123655

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1726800 - [remote] Use dedicated error class for command errors in MessageHandler

Depends on D123655

Add a dedicated Errors module to remote/shared/messagehandler, similar to shared/webdriver/Errors.jsm
Errors thrown from content process MessageHandler are serialized before being forwarded to the parent process.

We should probably make all errors inherit from a generic RemoteError class which would support the same serialization/deserialization API

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4490d6e92109
[remote] Use dedicated error class for command errors in MessageHandler r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/a3ac7e932f3a
[remote] Verify commands as early as possible in MessageHandler r=webdriver-reviewers,whimboo

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/4490d6e92109
https://hg.mozilla.org/mozilla-central/rev/a3ac7e932f3a