1726926 - Mailing lists named in Japanese characters will be warned that they are not valid email addresses

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[EarlgreyTea]

Attachment: is not a valid e-mail address.jpg

Steps to Reproduce:

1. Create a mailing list named "リスト".
2. Create a new message.
3. Open Contact Sidebar.
4. Add the mailing list to To: field.

Actual Results:

The mailing list is highlighted in red and the following tooltips are displayed.

リスト <リスト> is not a valid e-mail address

Expected Results:

Mailing lists named in Japanese characters should not be warned.

Regression window:

https://hg.mozilla.org/comm-central/pushloghtml?fromchange=a84d70e678b453f16894023f0d7754a60cf5fc29&tochange=e8d02f5ccc406e1cdc8ef1af5e4cb8faf1db6bd4

Comment 1

[Magnus Melin [:mkmelin]]

I can reproduce that.

From https://hg.mozilla.org/comm-central/rev/b1be1b24e8770bfe4c9eb75192668be1d8d54969#l1.51 very likely

Comment 2

[Lasana Murray]

Attachment: Bug 1726926 - Use same parameter type as in nsIAbManager for nsIAbDIrectory for getMailListFromName(). r=darktrojan

Comment 3

[Magnus Melin [:mkmelin]]

Let's get this landed as well.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fbbeadfaf124
Use same parameter type as in nsIAbManager for nsIAbDIrectory for getMailListFromName(). r=darktrojan

Comment 5

[Magnus Melin [:mkmelin]]

Please request 91 uplift

Comment 6

[Lasana Murray]

Comment on attachment 9237556 [details]
Bug 1726926 - Use same parameter type as in nsIAbManager for nsIAbDIrectory for getMailListFromName(). r=darktrojan

[Approval Request Comment]
Regression caused by (bug #): 1712601
User impact if declined: Japanese (and possibly other locale) characters are incorrectly flagged as invalid in email addresses
Testing completed (on c-c, etc.): trunk
Risk to taking this patch (and alternatives if risky): Should be minimal, this patch just changes the type used in the idl files.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9237556 [details]
Bug 1726926 - Use same parameter type as in nsIAbManager for nsIAbDIrectory for getMailListFromName(). r=darktrojan

[Triage Comment]
Approved for esr91

Comment 8

[Rob Lemley [:rjl]]

https://hg.mozilla.org/releases/comm-esr91/rev/acfa72f1c61d