1727075 - Downloads panel elements not visible on hover with high contrast and system theme enabled

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect, P3)

Description

[Gabi Cheta [:Gabi] Desktop QA]

Attachment: 2021-08-23_15h40_22.png

Affected versions

• Fx 92.0b7
• Fx 93.0a1

Affected platforms

• Windows 10x64

Steps to reproduce

1. Launch Firefox
2. Enable system theme for about:addons
3. Go to https://www.thinkbroadband.com/download and download some files
4. Enable high contrast
5. Open Download Panel and hover over Cancel download or Open containing folder

Expected result

• Download Panel elements are properly displayed with high contrast and system theme

Actual result

• Downloads panel elements not visible on hover with high contrast and system theme enabled

Regression range
Will search for a regression as soon as possible

Additional notes

• See attached screenshot

Comment 1

[Simona Badau, Desktop QA]

Found commit message:
Bug 1708690 - Use :where in button.css to allow easier color overrides. r=Itiel

pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=16eddcf3458b3609ec1763218c1b015d9eeb91c5&tochange=02c956ff0d2f2c3584939f6d1879dad39795738d

Comment 2

[Noah Pesta]

Attachment: Bug 1727075 - Updated download folder icon to be visible on hover in HCM. r=mhowell,mtigley

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebefb02bb4e6
Updated download folder icon to be visible on hover in HCM. r=mhowell,mtigley,desktop-theme-reviewers,dao

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ebefb02bb4e6

Comment 5

[Giorgia Nichita, Release Desktop QA]

Reproduced the issue using an affected Nightly build from 2021-08-23.

The issue is verified as fixed on latest Beta 94.0b3, Win 10x64.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR91 approval when you get a chance.

Comment 7

[Noah Pesta]

Comment on attachment 9241705 [details]
Bug 1727075 - Updated download folder icon to be visible on hover in HCM. r=mhowell,mtigley

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: User facing bug, low risk fix
• User impact if declined: Download icon will continue to not be visible when hovered on in HCM
• Fix Landed on Version: 94.0b3
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only one line of change. Has been reviewed in nightly.
• String or UUID changes made by this patch:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9241705 [details]
Bug 1727075 - Updated download folder icon to be visible on hover in HCM. r=mhowell,mtigley

Approved for 91.3esr.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/b8958955e731

Comment 10

[Giorgia Nichita, Release Desktop QA]

The issue is verified as fixed on 91.3.0esr, Win 10x64.