Closed
Bug 1708690
Opened 4 years ago
Closed 4 years ago
Use :where in button.css to allow easier color overrides
Categories
(Toolkit :: Themes, task, P1)
Toolkit
Themes
Tracking
()
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-cleanup] [proton-uplift])
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
No description provided.
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-1568
Whiteboard: [proton-cleanup]
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/02c956ff0d2f
Use :where in button.css to allow easier color overrides. r=Itiel
Comment 3•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Comment 4•4 years ago
|
||
I that something we should uplift to beta? Thanks
status-firefox89:
--- → affected
Flags: needinfo?(dao+bmo)
Assignee | ||
Comment 5•4 years ago
|
||
Comment on attachment 9219519 [details]
Bug 1708690 - Use :where in button.css to allow easier color overrides. r=Itiel
Beta/Release Uplift Approval Request
- User impact if declined: Bugs such as bug 1704195 and bug 1706155.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce: Bug 1704195 and bug 1706155 should be verified independently.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): I can't think of much that could break here. Has baked in Nightly for half a week.
- String changes made/needed:
Flags: needinfo?(dao+bmo)
Attachment #9219519 -
Flags: approval-mozilla-beta?
Updated•4 years ago
|
Whiteboard: [proton-cleanup] → [proton-cleanup] [proton-uplift]
Comment 6•4 years ago
|
||
Comment on attachment 9219519 [details]
Bug 1708690 - Use :where in button.css to allow easier color overrides. r=Itiel
Low risk, approved for 89 beta 8, thanks.
Attachment #9219519 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 7•4 years ago
|
||
bugherder uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•