Closed Bug 1708690 Opened 4 years ago Closed 4 years ago

Use :where in button.css to allow easier color overrides

Categories

(Toolkit :: Themes, task, P1)

task
Points:
2

Tracking

()

RESOLVED FIXED
90 Branch
Iteration:
90.1 - Apr 19 - May 2
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-cleanup] [proton-uplift])

Attachments

(1 file)

No description provided.
Whiteboard: [proton-cleanup]
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/02c956ff0d2f Use :where in button.css to allow easier color overrides. r=Itiel
Blocks: 1706155
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Blocks: 1708910
Blocks: 1704195

I that something we should uplift to beta? Thanks

Flags: needinfo?(dao+bmo)

Comment on attachment 9219519 [details]
Bug 1708690 - Use :where in button.css to allow easier color overrides. r=Itiel

Beta/Release Uplift Approval Request

  • User impact if declined: Bugs such as bug 1704195 and bug 1706155.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: Bug 1704195 and bug 1706155 should be verified independently.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): I can't think of much that could break here. Has baked in Nightly for half a week.
  • String changes made/needed:
Flags: needinfo?(dao+bmo)
Attachment #9219519 - Flags: approval-mozilla-beta?
Whiteboard: [proton-cleanup] → [proton-cleanup] [proton-uplift]

Comment on attachment 9219519 [details]
Bug 1708690 - Use :where in button.css to allow easier color overrides. r=Itiel

Low risk, approved for 89 beta 8, thanks.

Attachment #9219519 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Blocks: 1706591
Regressions: 1727075
See Also: → 1699133
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: