1727316 - ClearDataService cleaners over-clear for non user requests

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, defect, P1)

Description

[Emma Zühlcke [:emz]]

Cleaners which can't delete by principal or base domain fall back to clear all. This is intended for cases where the user triggered the data clearing, so we don't leave data behind. However, if we call the ClearDataService programmatically, we don't want to over-clear. It can lead to bugs like Bug 1721084 where we clear state unrelated to the origin/baseDomain passed.

Comment 1

[Emma Zühlcke [:emz]]

Attachment: Bug 1727316 - ClearDataService tests to ensure that we do not fallback to clearAll for non user requests. r=johannh!

Depends on D122881

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 1727316 - Avoid over-clearing data in ClearDataService if we do not have user input. r=johannh!

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/a0e4eaaf52a4
https://hg.mozilla.org/mozilla-central/rev/47891f98f8f5

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider taking on ESR91?

Comment 5

[Emma Zühlcke [:emz]]

Unless we see more bugs like Bug 1721084, where we break due to over-clearing, I don't think we need to uplift to ESR for now.
(For Bug 1721084 we uplifted a separate fix)