1727425 - Move website icons prefs from content pref pane to browser pref pane

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Ian Neal]

At the moment the browser specific website icon prefs sit in the content pref pane and would be better in one of the browser pref panes, the location bar one is probably a good place.
Whilst touching the content pref pane, add the missing accesskey for "Show zoom controls in the status bar" and help for that pref.

Comment 1

[Ian Neal]

Attachment: 1727425-website-icons-pref-25310.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: website icon prefs not a browser specific pref pane
Testing completed (on m-c, etc.): 2.53.10
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: 5 strings moved, 1 new string and help file changes

Comment 2

[Ian Neal]

Attachment: 1727425-prefs-website-icons-25310.patch

Move to main browser pane instead.

Comment 3

[Ian Neal]

Attachment: Screenshot from 2021-08-29 22-40-59.png

Browser pref pane with new prefs shown.

Comment 4

[Ian Neal]

Attachment: Screenshot from 2021-08-30 00-27-03.png

Possible rearrangement of pref pane

Comment 5

[Ian Neal]

Attachment: Screenshot from 2021-08-30 00-56-15.png

With horizontal radio buttons, though this might not work well for some locales

Comment 6

[Ian Neal]

Attachment: 1727425-prefs-website-icons-v1_1-25310.patch

Rearrange panel to 2nd screenshot layout.

Comment 7

[Ian Neal]

Attachment: 1727425-prefs-website-icons-v1_1-25310.patch

Fixed header

Comment 8

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9238572 [details] [diff] [review]
1727425-prefs-website-icons-v1_1-25310.patch

LGTM

The one thing which might need an improvement is that the top borders for the "Display on" and "When restoring sessions" are not on the same level. But would probably need another box around "Display on" so best to just don't change it.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a79f4e42f0fa
Move website icons prefs from content pref pane to browser pref pane. r=frg

Comment 10

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/a970f5613705246b7010fdb27e13266a6a889693
Move website icons prefs from content pref pane to browser pref pane. r=frg a=frg