Closed Bug 1727659 Opened 2 months ago Closed 2 months ago

Move browser / mailnews system integration prefs into advanced pane

Categories

(SeaMonkey :: Preferences, task)

Tracking

(seamonkey2.53? affected)

RESOLVED FIXED
seamonkey 2.90
Tracking Status
seamonkey2.53 ? affected

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

(Whiteboard: SM2.53.10)

Attachments

(1 file, 2 obsolete files)

At the moment various system integration prefs are spread between browser, mailnews and advanced pref panes. They should be moved to a single pref pane, advanced.

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: prefs spread across 3 different panes
Testing completed (on m-c, etc.): 2.53.10
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: changes to help content, 12 strings moved, 2 new strings, 7 strings removed

Attachment #9238086 - Flags: review?(frgrahl)
Attachment #9238086 - Flags: approval-comm-release?
Attachment #9238086 - Flags: approval-comm-esr60?
Blocks: 1727948
Blocks: 1727425

Don't remove hbox to make it easier for Bug 1727425

Attachment #9238086 - Attachment is obsolete: true
Attachment #9238086 - Flags: review?(frgrahl)
Attachment #9238086 - Flags: approval-comm-release?
Attachment #9238086 - Flags: approval-comm-esr60?
Attachment #9238485 - Flags: review?(frgrahl)
Attachment #9238485 - Flags: approval-comm-release?
Attachment #9238485 - Flags: approval-comm-esr60?

Comment on attachment 9238485 [details] [diff] [review]
1727659-prefs-systemsintegration-v1_1-25310.patch

LGTM

/suite/components/pref/content/pref-advanced.js

function InitPlatformIntegration() {
if (ShellService) try {
this.defaultApps = ShellService.shouldBeDefaultClientFor;

Can we indent this "normally".

function InitPlatformIntegration() {
if (ShellService) {
try {
this.defaultApps = ShellService.shouldBeDefaultClientFor;

Attachment #9238485 - Flags: review?(frgrahl)
Attachment #9238485 - Flags: review+
Attachment #9238485 - Flags: approval-comm-release?
Attachment #9238485 - Flags: approval-comm-release+
Attachment #9238485 - Flags: approval-comm-esr60?
Attachment #9238485 - Flags: approval-comm-esr60+

[Triage Comment]
Formatting fixed

Attachment #9238485 - Attachment is obsolete: true
Attachment #9239473 - Flags: review+
Attachment #9239473 - Flags: approval-comm-release+
Attachment #9239473 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/217c7d1ef14a
Move browser / mailnews system integration prefs into advanced pane. r=frg

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Whiteboard: SM2.53.10
Target Milestone: --- → seamonkey 2.90
You need to log in before you can comment on or make changes to this bug.