1727659 - Move browser / mailnews system integration prefs into advanced pane

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, task)

Description

[Ian Neal]

At the moment various system integration prefs are spread between browser, mailnews and advanced pref panes. They should be moved to a single pref pane, advanced.

Comment 1

[Ian Neal]

Attachment: 1727659-prefs-systemsintegration-25310.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: prefs spread across 3 different panes
Testing completed (on m-c, etc.): 2.53.10
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: changes to help content, 12 strings moved, 2 new strings, 7 strings removed

Comment 2

[Ian Neal]

Attachment: 1727659-prefs-systemsintegration-v1_1-25310.patch

Don't remove hbox to make it easier for Bug 1727425

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9238485 [details] [diff] [review]
1727659-prefs-systemsintegration-v1_1-25310.patch

LGTM

/suite/components/pref/content/pref-advanced.js

function InitPlatformIntegration() {
if (ShellService) try {
this.defaultApps = ShellService.shouldBeDefaultClientFor;

Can we indent this "normally".

function InitPlatformIntegration() {
if (ShellService) {
try {
this.defaultApps = ShellService.shouldBeDefaultClientFor;

Comment 4

[Ian Neal]

Attachment: 1727659-prefs-systemsintegration-v1_2-25310.patch

[Triage Comment]
Formatting fixed

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/217c7d1ef14a
Move browser / mailnews system integration prefs into advanced pane. r=frg

Comment 6

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/e563e2ef69c7b699240d6f5b247a982b78eb6e44
Move browser / mailnews system integration prefs into advanced pane. r=frg a=frg