1727668 - Integrate Merino with Firefox Suggest/quick suggest

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

https://mozilla-hub.atlassian.net/browse/SNT-21

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1727668 - Integrate Merino with Firefox Suggest/quick suggest.

This integrates a fetch to Merino in UrlbarProviderQuickSuggest. We continue to
do the remote settings fetch too. Per the Jira ticket, we should prefer the
Merino suggestion when both sources return one.

Each fetch is controlled by a new pref and Nimbus variable, so we can enable
them independently.

At first I started making a UrlbarProviderMerino class, but it's better to
modify UrlbarProviderQuickSuggest because everything besides the fetch source is
the same: We want to collect the same telemetry, have the same results and
payloads, etc.

Comment 2

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fea8e198cb18362793fcfa668c33ab20625c61e5

Comment 3

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=27267b10f900f016c10ee793c086bc18bcc148c7

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4867cab4560e
Integrate Merino with Firefox Suggest/quick suggest. r=mak,nanj

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4867cab4560e

Comment 6

[Drew Willcoxon :adw]

Pasting some useful links, mostly so I don't forget them:

• https://mozilla-services.github.io/merino/merino/docs/api/index.html
• https://mozilla-services.github.io/merino/merino/docs/dev/index.html
• https://mozilla-services.github.io/merino/merino_settings/index.html
• https://github.com/mozilla-services/merino

Comment 7

[Drew Willcoxon :adw]

qe-verify- because some urgent Firefox Suggest patches we want to uplift depend on this bug, but this bug is not related to the Firefox Suggest offline/online rollouts and does not need to be verified by QA for those rollouts. The feature added by this bug is also preffed off. Once it's enabled, we should have a round of QA for that feature (Merino integration) specifically.

Comment 8

[Drew Willcoxon :adw]

[Tracking Requested - why for this release]: Some urgent Firefox Suggest patches we want to uplift to a 92 dot release depend on this bug.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

We're tracking the metabug for this work.

Comment 10

[Drew Willcoxon :adw]

Attachment: 92/mozilla-release patch

Approval Request Comment
[Feature/Bug causing the regression]: Firefox Suggest offline/online rollouts (this bug is not directly related but code that is directly related depends on it)
[User impact if declined]: Needed for important rollouts on 93 and 92
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No, low-level change with no visible changes
[List of other uplifts needed for the feature/fix]: See uplift coordination spreadsheet
[Is the change risky?]: Low risk relative to other uplifts needed in the patch stack
[Why is the change risky/not risky?]: This patch integrates a second source of data for Firefox Suggest (Merino) but it's preffed off. No visible changes.
[String changes made/needed]:

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9240786 [details] [diff] [review]
92/mozilla-release patch

Approved for 92.0.1.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/fbd3ffb64690