Closed Bug 1727799 Opened 10 months ago Closed 10 months ago

Add telemetry probes to instrument the Merino remote queries

Categories

(Firefox :: Address Bar, enhancement, P1)

enhancement
Points:
3

Tracking

()

VERIFIED FIXED
93 Branch
Iteration:
93.2 - Aug 23 - Sep 5
Tracking Status
firefox93 --- fixed
firefox94 --- verified
firefox95 --- verified
firefox96 --- verified

People

(Reporter: nanj, Assigned: adw)

References

Details

Attachments

(2 files)

No description provided.
Severity: -- → N/A
Points: --- → 3
Priority: -- → P1
Assignee: nobody → adw
Status: NEW → ASSIGNED
Iteration: --- → 93.2 - Aug 23 - Sep 5

This uses TelemetryStopwatch to record the time between the fetch start and
its resolve. The new histogram is FX_URLBAR_MERINO_LATENCY.

A few questions:

  • I wasn't sure about a reasonable high and n_buckets for the histogram. I
    looked for other HTTP "latency" histograms, and there are two,
    HTTP_SUBITEM_OPEN_LATENCY_TIME and HTTP_SUBITEM_FIRST_BYTE_LATENCY_TIME.
    They both use high: 30000 and n_buckets: 50, which seem OK, so that's what
    I chose.
  • Is FX_URLBAR the right prefix for the histogram name? "Contextual services"
    might be better but I don't see any existing ones.
  • Is fx-search@mozilla.com the right email? Is there a contextual services
    group?

Depends on D123707

Attached file request.md

Data-review request for the new FX_URLBAR_MERINO_LATENCY_MS histogram.

Please also note that the patch updates the following fields for two existing histograms, PLACES_AUTOCOMPLETE_1ST_RESULT_TIME_MS and PLACES_AUTOCOMPLETE_6_FIRST_RESULTS_TIME_MS:

    "record_in_processes": ["main"],
    "products": ["firefox"],
    "alert_emails": [<fx-search>, <me>],
Attachment #9238739 - Flags: data-review?(teon)

Comment on attachment 9238739 [details]
request.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file Histograms.json and the Probe Dictionary.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :adw is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.


Result: datareview+

Attachment #9238739 - Flags: data-review?(teon) → data-review+
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1bce8ba91f7b
Add telemetry probe to measure Merino latency. r=mythmon,mak
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch

We have verified this bug on the latest Nightly 96.0a1 build (Build ID: 20211109190508) and the latest Beta 95.0b5 (Build ID: 20211109194756) and Firefox Release 94.0.1 on Windows 10 x64, macOS 10.15.7 and Ubuntu 20.04 x64.

  • In order to verify this issue we have enabled Merino and disabled RS then triggered a Sponsored/Non-Sponsored suggestion. The "FX_URLBAR_MERINO_LATENCY_MS" histogram is correctly registered when a Sponsored/Non-Sponsored suggestion from Merino is displayed.
Status: RESOLVED → VERIFIED
See Also: → 1743885
You need to log in before you can comment on or make changes to this bug.