1727785 - Sub-sections of "Enhanced Tracking" aren't readable with HCM enabled

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Morgan Reschenberg [:morgan]]

See comment on previous bug here: https://bugzilla.mozilla.org/show_bug.cgi?id=1723742#c28

STR:

On MacOS - enable Increase Contrast in system settings
Enable HCM (about:preferences > Language and Appearance > Colors > Always)
Visit the security section of preferences
Select "strict" or "custom"

Expected:
The text in the sub-section is readable

Actual:
The text in the sub section is rendered white-on-white

Comment 1

[:Gijs (out for now; he/him)]

This might be a better fit for the MSU folks, seeing as we're already going to ship this in 92, whether it gets fixed in 93 or 94 is less critical I suppose...

Comment 2

[Micah [:mtigley] (she/her)]

Yes, let's have the folks at MSU take a look at this as part of this semester's project! Thanks!

Comment 3

[Shaoting Huang]

Sorry it is me again, I'm using MacOS for the replication of this bug, but still, I'm unable to replicate this.
Here is what I did,
macOS Big Sur Version 11.5.2
enable HCM thru settings
Nightly build go to address bar and type about:preference and go to Privacy & Security and enable either Strict or Custom,
the Heads up sub section is still readable and not white on white
Is there something in the steps you did not mention or missing?
Thanks

Comment 4

[Micah [:mtigley] (she/her)]

I'm also not able to reproduce this on MacOS version 95.0a1.

Comment 5

[Morgan Reschenberg [:morgan]]

This might've been fixed by bug 1723742 or by bug 1730603

Comment 6

[Micah [:mtigley] (she/her)]

(In reply to Shaoting Huang from comment #3)

Sorry it is me again, I'm using MacOS for the replication of this bug, but still, I'm unable to replicate this.
Here is what I did,
macOS Big Sur Version 11.5.2
enable HCM thru settings
Nightly build go to address bar and type about:preference and go to Privacy & Security and enable either Strict or Custom,
the Heads up sub section is still readable and not white on white
Is there something in the steps you did not mention or missing?
Thanks

You can use a tool called mozregression, which is something we use for Mozilla code to find regression ranges. Although in this case, we want to find the fix and we can do this with mozregression --find-fix. See here for more documentation on this tool.

Once you find the commit that fixed this (and it's probably one of the issues that Morgan mentioned in Comment 5) , we can close this issue with a comment saying which bug it was.

Comment 7

[Shaoting Huang]

Here is what I got:
12:04.52 INFO: Narrowed integration fix window from [f31a22da, b7d27172] (4 builds) to [47891f98, b7d27172] (2 builds) (~1 steps left)

12:04.52 INFO: No more

integration revisions, bisection finished.

12:04.52 INFO: First good revision: b7d27172ebfa09998106e1d839eaaa@facfb4351

12:04.52 INFO: Last bad revision: 47891f98f8f5ac7a13ecc31aac9cc0f467f26673

12:04.52 INFO: Pushlog:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=47891f98f8f5ac7a13ecc31aac9cc0f467f26673&tochange=b7d27172ebfa09998106e1d839eaaa0facfb4351

Comment 8

[Micah [:mtigley] (she/her)]

Looks good to me! Thanks for investigating this, Shao.

Comment 9

[Alin Ilea, Desktop Test Engineering]

Tested with Fx 92,93 and latest Nightly 96.0a1 (2021-11-03), using Windows 10 and macOS 10.15 and I can confirm that this issue is fixed. The text in the Enhanced Tracking Protection sub-section is readable in high contrast mode.