1728025 - Stop using canonical name as collection keys

Status: RESOLVED FIXED

(SeaMonkey :: Chat, defect)

Description

[Ian Neal]

+++ This bug was initially created as a clone of Bug #498178 +++

Two potential solutions:

1. Implement a Dictionary/Mapping class to handle collections that avoids name clashes. This would require methods to replace iteration, getting and setting - and thus lots of code changes

2. Instead of using cannonicalName as the key, create a new property (collectionKeyName perhaps?) which is prefixed with some character which would be invalid for real methods.

The second of these is probably the better choice for this bug.

Comment 1

[Ian Neal]

Cherry pick the relevant parts of the following checkins from the ambassador fork:
https://github.com/Ascrod/ambassador/commit/73ab1d9612b97f381af5a5e0d03fd11e27145737
https://github.com/Ascrod/ambassador/commit/9b998ce1179ac618fe433f0f179a7ed37df66816
https://github.com/Ascrod/ambassador/commit/20b49ca5e64a2537a0691711cb3c749ad6ec3f51
https://github.com/Ascrod/ambassador/commit/d6e0c341fc135f8b22624e0e4f7822b60adfc9a5

Whilst here fix-up some strict JS warnings and correct what is iterated against for channel users in serv_005 function.

Comment 2

[Ian Neal]

Attachment: 1728025-irc-collectionkeys-25310.patch

[Triage Comment]
r/a=me

Comment 3

[Ian Neal]

Attachment: 1728025-irc-collectionkeys-25310.patch

Fixed bitrotting

Comment 4

[Ian Neal]

Attachment: 1728025-irc-collectionkeys-v1_1-25310.patch

Fix more bit rotting from Bug 1724586

Comment 5

[Ian Neal]

Comment on attachment 9239219 [details] [diff] [review]
1728025-irc-collectionkeys-v1_1-25310.patch

[Triage Comment]
r/a=me

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b9515e0db914
Stop using canonical name as collection keys. r=IanN

Comment 7

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/71259250bc255a6081a4f66c72b07eaa9bdfc9e7
Stop using canonical name as collection keys. r=IanN a=IanN