Closed Bug 1728027 Opened 2 months ago Closed 12 days ago

helper function for renaming irc server properties

Categories

(SeaMonkey :: Chat, task)

Tracking

(seamonkey2.53? affected)

RESOLVED FIXED
seamonkey 2.92
Tracking Status
seamonkey2.53 ? affected

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

(Whiteboard: SM2.53.10)

Attachments

(1 file, 1 obsolete file)

There is a certain amount of code duplication in IRCServer serv_005 function. Providing a helper function could remove that duplication.

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.10
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9238424 - Flags: review?(frgrahl)
Attachment #9238424 - Flags: approval-comm-release?
Attachment #9238424 - Flags: approval-comm-esr60?

Comment on attachment 9238424 [details] [diff] [review]
1728027-irc-renameProperties-25310.patch

LGTM

NIT:

  •        this.renameProperties(item[child]);
    

Shouldn't this be this.renameProperties(item[child], null); for consistency with this.renameProperties(this.users, null); ?

r/a+ with this changed or not.

Attachment #9238424 - Flags: review?(frgrahl)
Attachment #9238424 - Flags: review+
Attachment #9238424 - Flags: approval-comm-release?
Attachment #9238424 - Flags: approval-comm-release+
Attachment #9238424 - Flags: approval-comm-esr60?
Attachment #9238424 - Flags: approval-comm-esr60+

[Triage Comment]
Carrying forward r/a+

Attachment #9238424 - Attachment is obsolete: true
Attachment #9245100 - Flags: review+
Attachment #9245100 - Flags: approval-comm-release+
Attachment #9245100 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/ad48a87cef1a
helper function for renaming irc server properties. r=frg

Status: ASSIGNED → RESOLVED
Closed: 12 days ago
Resolution: --- → FIXED
Whiteboard: SM2.53.10
Target Milestone: --- → seamonkey 2.92
You need to log in before you can comment on or make changes to this bug.