1728027 - helper function for renaming irc server properties

Status: RESOLVED FIXED

(SeaMonkey :: Chat, task)

Description

[Ian Neal]

There is a certain amount of code duplication in IRCServer serv_005 function. Providing a helper function could remove that duplication.

Comment 1

[Ian Neal]

Attachment: 1728027-irc-renameProperties-25310.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.10
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9238424 [details] [diff] [review]
1728027-irc-renameProperties-25310.patch

LGTM

NIT:

•        this.renameProperties(item[child]);
  

Shouldn't this be this.renameProperties(item[child], null); for consistency with this.renameProperties(this.users, null); ?

r/a+ with this changed or not.

Comment 3

[Ian Neal]

Attachment: 1728027-irc-renameProperties-v1_1-25310.patch

[Triage Comment]
Carrying forward r/a+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ad48a87cef1a
helper function for renaming irc server properties. r=frg

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/40cd1572e39881903db7a2de5d15a87994ed7a09
helper function for renaming irc server properties. r=frg a=frg