1728182 - Unify js::intl_GetLocaleInfo

Status: RESOLVED FIXED

(Core :: Internationalization, task, P3)

Description

[Greg Tatum [:gregtatum]]

Work Amount: Small
What it is: uloc_isRightToLeft
Searchfox: https://searchfox.org/mozilla-central/source/js/src/builtin/intl/IntlObject.cpp#497

Comment 1

[André Bargull [:anba]]

Bug 1693576 will add a similar functionality: intl_GetLocaleInfo calls uloc_isRightToLeft to determine LTR or RTL, whereas bug 1693576 calls uloc_getCharacterOrientation. Unfortunately I couldn't find where intl_GetLocaleInfo is actually used, outside of test code (https://searchfox.org/mozilla-central/search?q=symbol:%23getLocaleInfo&redirect=false), so I can't tell if this difference is relevant.

Comment 2

[André Bargull [:anba]]

Ah, it looks like all callers were removed in bug 1673054, so we can simply remove intl_GetLocaleInfo

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1728182 - Part 1: Remove getLocaleInfo from dom. r=#platform-i18n-reviewers!

getLocaleInfo is never used outside of test code, so we can simply remove it.

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1728182 - Part 2: Remove getLocaleInfo from toolkit. r=#platform-i18n-reviewers!

Depends on D125160

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1728182 - Part 3: Remove getLocaleInfo from SpiderMonkey. r=#platform-i18n-reviewers!

This function is no longer used after parts 1-2.

Depends on D125163

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5180c12a46b
Part 1: Remove getLocaleInfo from dom. r=platform-i18n-reviewers,dminor,webidl,emilio
https://hg.mozilla.org/integration/autoland/rev/76596947c241
Part 2: Remove getLocaleInfo from toolkit. r=platform-i18n-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/561ed5ccdd24
Part 3: Remove getLocaleInfo from SpiderMonkey. r=platform-i18n-reviewers,dminor

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e5180c12a46b
https://hg.mozilla.org/mozilla-central/rev/76596947c241
https://hg.mozilla.org/mozilla-central/rev/561ed5ccdd24