1728296 - Accessibility regression: Account Settings tree item names disappear

Status: VERIFIED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Valentin Villenave]

Attachment: Capture du 2021-08-31 12-19-45.png

This is a follow-up to #1728087.

I found something even better (by which I mean worse):

• Open the Account Settings tab.
• Check the list box on the left (it opens on your Local Folders or on your email account by default).
• Hit Tab a bunch of times until you reach the “Account Name” field on the right.
• Hit Tab just once more to move on to the next item.
• In the list on the left, your account name has now become blank. The item’s still there, it just no longer has any name.

(Actually if you reach it, at-spi will still have the oh-so-palatable name “Server Settings Copies & Folders Composition & Addressing Junk Settings Synchronization & Storage End-To-End Encryption Return Receipts”, but that appears to be a side effect of #1728087. None of that is displayed anyway.)

Comment 1

[Magnus Melin [:mkmelin]]

(when refrencing bugs, please just write "bug " and the number so that bugzilla can autolink properly)

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1728296 - Remove second argument in calls to setAccountLabel. r=aleca

The function was changed but not all callers were updated. Also adds an ARIA label to top-level Account Manager items.

Comment 3

[Geoff Lankow (:darktrojan)]

Oops. Thanks for the report. The accessible label should be fixed with this patch too.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c56061f8a4f7
Remove second argument in calls to setAccountLabel. r=aleca

Comment 5

[Valentin Villenave]

I can confirm that it’s no longer reproduced with build 20210901105030. Great job!