1728760 - Make all native nsITimerCallback implementations also implement nsINamed

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Florian Quèze [:florian]]

Bug 1382172 did this 4 years ago, and we now have many new nsITimerCallback implementations that don't implement nsINamed. It would be nice to ensure at compile time that all native nsITimerCallback implementations also implement nsINamed.

These names are exposed in profiler markers (from bug 1688300 and bug 1728228).

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1728760 - require all nsITimerCallback native implementations to also implement nsINamed, r=smaug.

Comment 2

[Florian Quèze [:florian]]

Attachment: Bug 1728760 - move the nsHttpChannel nsITimerCallback implementation to a nested subclass to avoid issues when an object implements both nsIChannel and nsIRequest, r=smaug.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79474e4c8adf
require all nsITimerCallback native implementations to also implement nsINamed, r=smaug.
https://hg.mozilla.org/integration/autoland/rev/5710a72e4438
move the nsHttpChannel nsITimerCallback implementation to a nested subclass to avoid issues when an object implements both nsIChannel and nsIRequest, r=smaug,necko-reviewers,kershaw.

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/79474e4c8adf
https://hg.mozilla.org/mozilla-central/rev/5710a72e4438