1729689 - Bustage nsHTTPSOnlyUtils.h: error: static_assert failed due to requirement 'std::is_convertible<TestHTTPAnswerRunnable *, nsINamed *>::value' "nsITimerCallback implementations must also implement nsINamed" when Gecko 94 merges to Beta on 2021-10-04

Status: VERIFIED FIXED

(Core :: XPCOM, defect)

Description

[Natalia Csoregi [:nataliaCs]]

[Tracking Requested - why for this release]:

• Central-as-beta
• How to run these simulations
• Failure log

[task 2021-09-08T11:08:35.942Z] 11:08:35     INFO -  In file included from /builds/worker/checkouts/gecko/docshell/base/nsDocShell.cpp:87:
[task 2021-09-08T11:08:35.942Z] 11:08:35    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/nsHTTPSOnlyUtils.h:229:3: error: static_assert failed due to requirement 'std::is_convertible<TestHTTPAnswerRunnable *, nsINamed *>::value' "nsITimerCallback implementations must also implement nsINamed"
[task 2021-09-08T11:08:35.942Z] 11:08:35     INFO -    NS_DECL_NSITIMERCALLBACK
[task 2021-09-08T11:08:35.942Z] 11:08:35     INFO -    ^~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-09-08T11:08:35.942Z] 11:08:35     INFO -  /builds/worker/workspace/obj-build/dist/include/nsITimer.h:302:5: note: expanded from macro 'NS_DECL_NSITIMERCALLBACK'
[task 2021-09-08T11:08:35.942Z] 11:08:35     INFO -      static_assert(std::is_convertible<decltype(this), nsINamed*>::value, \
[task 2021-09-08T11:08:35.942Z] 11:08:35     INFO -      ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-09-08T11:08:35.943Z] 11:08:35     INFO -  1 error generated.
[task 2021-09-08T11:08:35.943Z] 11:08:35    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:676: Unified_cpp_docshell_base0.o] Error 1
[task 2021-09-08T11:08:35.943Z] 11:08:35     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/docshell/base'
[task 2021-09-08T11:08:35.944Z] 11:08:35    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: docshell/base/target-objects] Error 2
[task 2021-09-08T11:08:35.944Z] 11:08:35     INFO -  gmake[3]: *** Waiting for unfinished jobs....

Comment 1

[Natalia Csoregi [:nataliaCs]]

This seems to have been caused by Bug 1728760.

Florian, could you help us out please?

Beta-simulation after backing out But 1728760 with all builds passed: https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=76720bced240de468e44d808ec52f306c7d902be&searchStr=build

Comment 2

[Florian Quèze [:florian]]

It happens because of the ifdefs at https://searchfox.org/mozilla-central/rev/a166f59fba89fc70ebfab287f4edb8e05ed4f6da/xpcom/threads/nsThreadUtils.h#369-371,375

The simplest solution is probably to add an #ifndef RELEASE_OR_BETA around https://searchfox.org/mozilla-central/rev/a166f59fba89fc70ebfab287f4edb8e05ed4f6da/xpcom/threads/nsITimer.idl#323-329

Comment 3

[Florian Quèze [:florian]]

Attachment: Bug 1729689 - Do not require nsITimerCallback implementations to implement nsINamed on release or beta, as runnables don't have names there, r=smaug.

Comment 4

[Florian Quèze [:florian]]

Natalia, does this patch help?

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Yes, the patch fixes the bustage (patch is not shown because it was part of an earlier push which got automatically built as artifact build).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68172b4ec39f
Do not require nsITimerCallback implementations to implement nsINamed on release or beta, as runnables don't have names there, r=smaug.

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/68172b4ec39f

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed in today's central-as-early-beta simulation.