1728871 - Support fetching data from Remote Setting

Status: ASSIGNED

(Toolkit :: Safe Browsing, enhancement, P2)

Description

[Dimi Lee [:dimi][:dlee]]

Here is a quick note summarizing what needs to be done to support fetching data from Remote Setting in the url-classifier

Implement a service under toolkit/component/url-classifier to fetch data from RemoteSetting
Make URLClassifier aware that the list should come from RemoteSetting instead of shavar. Possible solutions include:
Add a custom url in browser.safebrowsing.provider.mozilla.updateURL pref , ex: rs://collection-name
Process the custom URL in nsUrlClassifierStreamUpdater (probably here). We should fetch data from the remote setting service instead of creating a http channel.
The service should fetch data from RemoteSetting and feed the data to URLClassifier through nsIStreamListener.idl interface

Still need to confirm:
Will the data from the remote setting contain all the available tables? Is it keyed by the table name?

Comment 1

[Dimi Lee [:dimi][:dlee]]

Attachment: WIP: Bug 1728871 - WIP

Comment 2

[Dimi Lee [:dimi][:dlee]]

Attachment: Bug 1728871 - P1. Add UrlClassifierRemoteSettingsService to serve update data over RemoteSettings

Comment 3

[Dimi Lee [:dimi][:dlee]]

Attachment: Bug 1728871 - P2. Add testcasers for UrlClassifierRemoteSettingsService

Depends on D135989

Comment 4

[Dimi Lee [:dimi][:dlee]]

Attachment: Bug 1728871 - P3. Add the URLCLASSIFIER_UPDATE_REMOTE_SETTING_RESULT telemetry

We can use this telemetry to track the statistics of using
RemoteSettings to serve Safe Browsing data.
The can help us understand if we can roll out this feature to more users.

Depends on D135990

Comment 5

[Release mgmt bot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:dimi, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 6

[Dimi Lee [:dimi][:dlee]]

We plan to add a version number in the RemoteSettings records, so there will be some changes in this patch.
I'm now waiting for the records to be updated to the server so I can continue the work.