No generated sources are uploaded for mac aarch64 builds
Categories
(Firefox Build System :: Task Configuration, defect)
Tracking
(firefox99 fixed)
| Tracking | Status | |
|---|---|---|
| firefox99 | --- | fixed |
People
(Reporter: mstange, Assigned: jcristau)
Details
Attachments
(1 file)
It looks like macOS aarch64 builds only upload symbols, but not generated sources.
Example: https://treeherder.mozilla.org/jobs?repo=mozilla-central&revision=18d7ddf67682e3eb75376f56e4f014c81d2596b3&searchStr=shippable%2Cmac
The "OS X AArch64 Cross Compiled Shippable" row has a "B" job and a "Sym" job, but no "Ugs" job.
This means that the .sym files of these builds refer to URLs that don't exist, for example this file does not exist on the server:
https://gecko-generated-sources.s3.amazonaws.com/31533cf475640be87b1760bbbbf6cbd082898861e4014ff754bab2fec7e7b6c3e63987234540e2ec0a33d87c2cc92eca3d775252919bca543a89df2b07fe1c66/aarch64-apple-darwin/release/build/swgl-ad773ae2d881b08a/out/brush_solid_ALPHA_PASS.h
For comparison, here's a URL from the x86_64 build which does exist:
https://gecko-generated-sources.s3.amazonaws.com/31533cf475640be87b1760bbbbf6cbd082898861e4014ff754bab2fec7e7b6c3e63987234540e2ec0a33d87c2cc92eca3d775252919bca543a89df2b07fe1c66/x86_64-apple-darwin/release/build/swgl-a0129b8bc43a0d67/out/brush_solid_ALPHA_PASS.h
|
||
Comment 1•4 years ago
|
||
The upload-generated-sources task is happening on the macosx64-shippable/opt task, but it would need to happen on macosx64-x64-shippable/opt and macosx64-aarch64-shippable/opt.
|
Reporter | |
Comment 2•4 years ago
|
||
It seems like the suggestion from comment 1 would run into the same problem as bug 1753621. Julien, once you've decided on a way forward in bug 1753621, could you update this bug to say what should happen?
|
Assignee | |
Comment 3•4 years ago
|
||
The problem I'm hitting in bug 1753621 is exceeding a 2GB upload limit, I don't think that would affect this task.
|
|
Reporter | |
Comment 4•4 years ago
•
|
||
Oh, what I mean is, if we make the upload-generated-sources tasks happen on macosx64-x64-shippable/opt and macosx64-aarch64-shippable/opt, as proposed in comment 1, would they be triggered by the "nightly_macosx" task, or would we unintentionally skip them just as we are currently skipping the upload-symbols tasks (which is what bug 1753621 is about)? And would we need a similar workaround, such as unifying the generated sources from both builds and then uploading them from the unified build?
|
|
Assignee | |
Comment 5•4 years ago
•
|
||
Hah, sorry. Currently, https://searchfox.org/mozilla-central/rev/e66593593f3b356901011ea0fcdf9979728e9ae8/taskcluster/ci/upload-generated-sources/kind.yml#15 means there's no upload-generated-sources for the x64 and aarch64 builds, only for the combined macosx64-shippable build (the one with the "shippable" attribute), and https://searchfox.org/mozilla-central/rev/e66593593f3b356901011ea0fcdf9979728e9ae8/taskcluster/scripts/misc/unify.sh uses the target.generated-files.tar.gz artifact from the x64 build task.
|
|
Assignee | |
Comment 6•4 years ago
|
||
If we can somehow unify both artifacts that might be best, if not I'm not sure how best to get the x64 and aarch64 tasks scheduled :/
|
|
Assignee | |
Comment 7•4 years ago
|
||
|
||
Updated•4 years ago
|
|
||
Comment 9•4 years ago
|
||
| bugherder | ||
|
|
Reporter | |
Comment 10•4 years ago
|
||
Thank you for fixing this!
The profiler can now successfully view source code for generated SWGL functions in this profile: https://share.firefox.dev/35L3P84
Description
•