Closed Bug 1728928 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30321 - Update/extend image-set parsing/serialization tests

Categories

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Product:
Core
Component:
Layout: Images, Video, and HTML Frames
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
94 Branch
Tracking Flags:
Tracking Status
firefox94 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30321 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30321
Details from upstream follow.

b'Sam Sneddon <gsnedders@apple.com>' wrote:

Update/extend image-set parsing/serialization tests

This:

  • moves these to use the normal helpers in /css/support/, which:
    • expands coverage beyond mere parsability to serialization,
  • merges the previously tentative webkit tests into the main files,
  • introduces tests for the computed values of image-set().
Component: web-platform-tests → Layout: Images, Video, and HTML Frames
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 50 subtests

Status Summary

Firefox

OK : 2
PASS: 66
FAIL: 6

Chrome

OK : 2
PASS: 20
FAIL: 52

Safari

OK : 2
PASS: 25
FAIL: 47

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-images/image-set/image-set-computed.sub.html
Property content value 'image-set(url('http://web-platform.test/example.png') 192dpi, linear-gradient(black, white) 1x)': FAIL (Chrome: FAIL, Safari: FAIL)
Property content value '-webkit-image-set(url('http://web-platform.test/example.png') 192dpi, linear-gradient(black, white) 1x)': FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-images/image-set/image-set-parsing.html
e.style['content'] = "image-set(linear-gradient(black, white) 1x, 'example.png' 4x)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['content'] = "-webkit-image-set(linear-gradient(black, white) 1x, 'example.png' 4x)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['content'] = "image-set(url("example.png") 192dpi, linear-gradient(black, white) 1x)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['content'] = "-webkit-image-set(url("example.png") 192dpi, linear-gradient(black, white) 1x)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ce73af6b73b5
[wpt PR 30321] - Update/extend image-set parsing/serialization tests, a=testonly
https://hg.mozilla.org/integration/autoland/rev/89d941290686
[wpt PR 30321] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ce73af6b73b5
https://hg.mozilla.org/mozilla-central/rev/89d941290686

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.