1729051 - Simplify imgFrame to only use shared surfaces for raster images

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, task, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

We don't use anything else anymore for raster images. We can greatly simplify this.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1729051 - Simplify imgFrame to only use shared surfaces for raster images.

In practice we already only use SourceSurfaceSharedData as our
rasterized image backing. This means we no longer need to lock the data
to keep it in memory (when we used volatile memory), nor to try to
optimize the surface for the DrawTarget.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bdf9c5f10cc
Simplify imgFrame to only use shared surfaces for raster images. r=jrmuizel

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing windows build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/adeee5d37d45a28c2aa98345a6ed79e93d6b1c00

Push with failures

Failure log

[task 2021-09-03T19:03:15.975Z] 19:03:15     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/ipc/SharedMemoryBasic_chromium.h(10,10): fatal error: 'base/shared_memory.h' file not found
[task 2021-09-03T19:03:15.975Z] 19:03:15     INFO -  #include "base/shared_memory.h"
[task 2021-09-03T19:03:15.975Z] 19:03:15     INFO -           ^~~~~~~~~~~~~~~~~~~~~~
[task 2021-09-03T19:03:15.975Z] 19:03:15     INFO -  1 error generated.```

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cab456c41ca9
Simplify imgFrame to only use shared surfaces for raster images. r=jrmuizel

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/cab456c41ca9