Closed Bug 1724935 (kill-layers) Opened 4 years ago Closed 2 years ago

[meta] Removal of legacy layers code

Categories

(Core :: Graphics, task, P5)

Product:
Core
Component:
Graphics
Type:
task

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: aosmond, Unassigned)

References

Details

(Keywords: meta)

No description provided.
Depends on: 1724936
Depends on: 1724738
Depends on: 1724943
Depends on: 1724794
Depends on: 1725388
Depends on: 1593381
Alias: kill-layers
Depends on: 1726672
Depends on: 1726291
Depends on: 1727395
Depends on: 1727360
Depends on: 1727324
Depends on: 1727398
Depends on: 1727423
Depends on: 1727488
Depends on: 1727489
Depends on: 1727447
Depends on: 1727435
Depends on: 1727430
Depends on: 1727623
Depends on: 1727639
Depends on: 1727661
Depends on: 1727672
Depends on: 1727676
Depends on: 1727682
Depends on: 1727683
Depends on: 1727684
Depends on: 1727634
Depends on: 1727774
Depends on: 1727807
Depends on: 1727814
Depends on: 1727823
Depends on: 1727876
Depends on: 1728004
Depends on: 1728107
Depends on: 1728112
Depends on: 1728113
Depends on: 1728152
Depends on: 1728202
Depends on: 1728205
Depends on: 1728193
Depends on: 1728195
Depends on: 1728240
Depends on: 1728311
Depends on: 1728350
Depends on: 1728466
Depends on: 1728411
Depends on: 1728498
Depends on: 1728890
Depends on: 1728903
Depends on: 1729051
Depends on: 1729117
Depends on: 1729841
Depends on: 1729076
Depends on: 1730055
No longer depends on: 1732222
Depends on: 1732443
Depends on: 1733094
No longer depends on: 1732352
Depends on: 1733288
Depends on: 1733294
Depends on: 1733296
Depends on: 1733601
Depends on: 1734502
Depends on: 1734506
Depends on: 1734511
Depends on: 1734571
Depends on: 1735261
Depends on: 1736077
Depends on: 1736497
Depends on: 1738152
Depends on: 1740410
Depends on: 1740411

Seems to be a LOT of "removes" lately. Is anybody keeping track, to see how much the overall program size is changing due to this? Isn't there a bug for that, or "footprint", or something like that?

Depends on: 1739621
Depends on: 1741111
Depends on: 1741121
Depends on: 1741123
Depends on: 1741775
Depends on: 1741783
Depends on: 1741784
Depends on: 1742052
Depends on: 1742739
Depends on: 1743319
Depends on: 1743325
Depends on: 1743332
Depends on: 1743335
Depends on: 1743521
Depends on: 1743743
Depends on: 1743930
Depends on: 1744086
Depends on: 1743955
Depends on: 1744087
Depends on: 1744666
Depends on: 1744868

Any idea how much this stripping out of code reduced file size? I'm guessing it at least kept it from increasing.

Looking at the size of the Firefox Linux package as an example (from http://ftp.mozilla.org/pub/firefox/releases/):

Firefox 91: 72M
Firefox 92: 72M
Firefox 93: 70M
Firefox 94: 71M
Firefox 95: 71M

I can't be sure that the drop in size from Firefox 92 (72M) to Firefox 93 (70M) is due to the removal of Layers code, but it's plausible.

Depends on: 1748968
Depends on: 1757587
Depends on: 1761872
Depends on: 1802225

(In reply to Worcester12345 from comment #2)

Any idea how much this stripping out of code reduced file size? I'm guessing it at least kept it from increasing.

(In reply to Botond Ballo [:botond] from comment #3)

Looking at the size of the Firefox Linux package as an example (from http://ftp.mozilla.org/pub/firefox/releases/):

Firefox 91: 72M
Firefox 92: 72M
Firefox 93: 70M
Firefox 94: 71M
Firefox 95: 71M

I can't be sure that the drop in size from Firefox 92 (72M) to Firefox 93 (70M) is due to the removal of Layers code, but it's plausible.

Not sure where you were pulling those numbers from, but could you show recent ones, so the comparison is apples to apples?

How much is left?

(In reply to Worcester12345 from comment #4)

(In reply to Botond Ballo [:botond] from comment #3)

Looking at the size of the Firefox Linux package as an example (from http://ftp.mozilla.org/pub/firefox/releases/):

Firefox 91: 72M
Firefox 92: 72M
Firefox 93: 70M
Firefox 94: 71M
Firefox 95: 71M

I can't be sure that the drop in size from Firefox 92 (72M) to Firefox 93 (70M) is due to the removal of Layers code, but it's plausible.

Not sure where you were pulling those numbers from

For example at http://ftp.mozilla.org/pub/firefox/releases/91.0.2/linux-x86_64/en-US/, the size of firefox-91.0.2.tar.bz2 is 73M. (Not sure where I got 72M from, may have been a different point release.)

but could you show recent ones, so the comparison is apples to apples?

I'm not sure what you mean. The major code removals here occurred around Firefox 93, if there was any impact at all on package size it would have been around then, not more recently.

How much is left?

If you mean how much removal of layers-related code is left, it's basically all done (and was already done in 2021). The remaining pieces that we occasionally discover (e.g. bug 1802225) are small odds and ends, and I certainly wouldn't expect them to have any impact on package size.

Depends on: 1831269
Depends on: 1842418

This meta bug hasn't had any activity and all its dependencies are closed. Could this be closed now?

Flags: needinfo?(bhood)

I'll let the reporter make the call: Andrew, what say you?

Flags: needinfo?(bhood) → needinfo?(aosmond)

Sure. I don't think there is much left, if any.

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(aosmond)
Resolution: --- → FIXED
Depends on: 1887521
You need to log in before you can comment on or make changes to this bug.