1729111 - Make `HTMLEditUtils::IsVisibleTextNode()` not use `WSRunScanner`

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

WSRunScanner is designed for handling only editable content, but IsVisibleTextNode() should not work with editable state check.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1729111 - part 1: Make `HTMLEditUtils.h` avoud using `dom::` at using classes in the namespace r=m_kato!

Depends on D123876

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1729111 - part 2: Split scanning following content part of `HTMLEditUtils::IsVisibleBRElement()` r=m_kato!

Depends on D124552

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1729111 - part 3: Rewrite `HTMLEditUtils::IsVisibleTextNode()` without `WSRunScanner` r=m_kato!

WSRunScanner is designed for scanning editable nodes, but
IsVisibleTextNode() should not check editable state. Therefore, it should
check it without WSRunScanner like IsVisibleBRElement().

Depends on D124553

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Changing severity to N/A because of a task for fixing the wrong design.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7d51d4e4a3c
part 1: Make `HTMLEditUtils.h` avoud using `dom::` at using classes in the namespace r=m_kato
https://hg.mozilla.org/integration/autoland/rev/0d218ad033af
part 2: Split scanning following content part of `HTMLEditUtils::IsVisibleBRElement()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/d1e96fb23d43
part 3: Rewrite `HTMLEditUtils::IsVisibleTextNode()` without `WSRunScanner` r=m_kato

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b7d51d4e4a3c
https://hg.mozilla.org/mozilla-central/rev/0d218ad033af
https://hg.mozilla.org/mozilla-central/rev/d1e96fb23d43