1729458 - Make process switches take fewer trips through the event loop

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement)

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1729458 - Part 2: Make process switches take fewer trips through the event loop, r=smaug

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1729458 - Part 1: Simplify DomPromiseListener, r=smaug

This makes a couple of changes, including removing the call to
AppendNativeHandler from the constructor, and using the nullable nature of
std::function instead of wrapping them in Maybe.

The main advantage of this change, however, is that it no longer acquires a
reference to this during the constructor, which could be unsafe.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8db01010657
Part 1: Simplify DomPromiseListener, r=smaug,rpl
https://hg.mozilla.org/integration/autoland/rev/42b3a9930fe0
Part 2: Make process switches take fewer trips through the event loop, r=smaug

Comment 4

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1729458) for causing leaks in ClientManagerService.
Backout link: https://hg.mozilla.org/integration/autoland/rev/08affc9cf11251a185568043323f2e2bf9e2dd65
Link with failures, failure log.

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1729458 - Part 3: Clean up future client sources during shutdown, r=asuth

Depends on D124800

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/704dd03288b1
Part 1: Simplify DomPromiseListener, r=smaug,rpl
https://hg.mozilla.org/integration/autoland/rev/72b7a9c7bf30
Part 2: Make process switches take fewer trips through the event loop, r=smaug
https://hg.mozilla.org/integration/autoland/rev/16b385e15fad
Part 3: Clean up future client sources during shutdown, r=asuth

Comment 7

[Chris Peterson [:cpeterson]]

Patches are too big to uplift. Perf improvement is expected to be small.

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing multiple dt failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/089fb1e6379b180a8474e1ea22a5aec4c4ec224c

Push with failures

Failure log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05ca4bd50219
Part 1: Simplify DomPromiseListener, r=smaug,rpl
https://hg.mozilla.org/integration/autoland/rev/63edcdef3b68
Part 2: Make process switches take fewer trips through the event loop, r=smaug
https://hg.mozilla.org/integration/autoland/rev/151359d48f18
Part 3: Clean up future client sources during shutdown, r=asuth

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/05ca4bd50219
https://hg.mozilla.org/mozilla-central/rev/63edcdef3b68
https://hg.mozilla.org/mozilla-central/rev/151359d48f18