1729499 - Day/Week view can (inconsistently) produce squashed hour lines.

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Henry Wilkes (they/them) [:henry-x]]

Steps to reproduce

Note: my windows manager is wayland.

1. Open calendar (in non-rotated view).
2. Grab the bottom edge of the window and drag up, and back.
3. Grab a bottom corner of the window and drag up, and back.
4. Grab the bottom edge of the window and drag up, then fullscreen and then un-fullscreen the window.

Result

In stages 3 and 4, the hour lines become very close together (the pixels per minute is very small).

Expect

Similar to stage 2, there should be a minimal pixels per minute.

Comment 1

[Lasana Murray]

For these kinds of bugs, a screenshot could be helpful.

Comment 2

[Henry Wilkes (they/them) [:henry-x]]

D132244 for bug 1713130 will make stages 2 constituent with 3 and 4. But there's still the issue of the minimum pixels per minute being too small.

Comment 3

[Henry Wilkes (they/them) [:henry-x]]

Attachment: small-pixels-per-minute.png

Here's the example of the small pixels per minute. The minimum is currently 0.1 https://searchfox.org/comm-central/rev/24389a8c5ecf3e4b3bf30af9c51a6c09a936ca63/calendar/base/content/calendar-multiday-view.js#2136 which would be 144 pixels for the entire day.

Comment 4

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1729499 - Choose a minimum pixelsPerMinute based on the timebar. r=darktrojan

We choose a minimum pixelsPerMinute such that the timebar labels do not overflow.

Depends on D133369

Comment 5

[Henry Wilkes (they/them) [:henry-x]]

Please check in after D133369 (bug 1713130)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1bc7809eec69
Choose a minimum pixelsPerMinute based on the timebar. r=darktrojan