Closed Bug 1729499 Opened 10 months ago Closed 7 months ago

Day/Week view can (inconsistently) produce squashed hour lines.

Categories

(Calendar :: Calendar Frontend, defect)

defect

Tracking

(thunderbird_esr91 unaffected)

RESOLVED FIXED
97 Branch
Tracking Status
thunderbird_esr91 --- unaffected

People

(Reporter: henry, Assigned: henry)

References

Details

Attachments

(2 files)

Steps to reproduce

Note: my windows manager is wayland.

  1. Open calendar (in non-rotated view).
  2. Grab the bottom edge of the window and drag up, and back.
  3. Grab a bottom corner of the window and drag up, and back.
  4. Grab the bottom edge of the window and drag up, then fullscreen and then un-fullscreen the window.

Result

In stages 3 and 4, the hour lines become very close together (the pixels per minute is very small).

Expect

Similar to stage 2, there should be a minimal pixels per minute.

No longer depends on: 1713130
Depends on: 1738689

For these kinds of bugs, a screenshot could be helpful.

D132244 for bug 1713130 will make stages 2 constituent with 3 and 4. But there's still the issue of the minimum pixels per minute being too small.

Depends on: 1713130
No longer depends on: 1738689

Here's the example of the small pixels per minute. The minimum is currently 0.1 https://searchfox.org/comm-central/rev/24389a8c5ecf3e4b3bf30af9c51a6c09a936ca63/calendar/base/content/calendar-multiday-view.js#2136 which would be 144 pixels for the entire day.

Assignee: nobody → henry
Status: NEW → ASSIGNED
Summary: Day/Week view can inconsistently produce squashed hour lines. → Day/Week view can (inconsistently) produce squashed hour lines.

We choose a minimum pixelsPerMinute such that the timebar labels do not overflow.

Depends on D133369

Please check in after D133369 (bug 1713130)

Target Milestone: --- → 97 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/1bc7809eec69
Choose a minimum pixelsPerMinute based on the timebar. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.