Port bug 1728708 changes to Thunderbird: Clean up for lwbrk WordBreaker and its gtest
Categories
(Thunderbird :: Upstream Synchronization, task, P1)
Tracking
(thunderbird_esr91 unaffected, thunderbird93 unaffected)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr91 | --- | unaffected |
| thunderbird93 | --- | unaffected |
People
(Reporter: mkmelin, Assigned: mkmelin)
References
Details
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1728708 +++
nsBayesianFilter.cpp was using WordBreaker getClass and such which are now private after https://hg.mozilla.org/mozilla-central/rev/3a38d2e56bf8
I don't know what the long term solution should be. This file seems to keep accumulating old junk... To get Thunderbird building again I'll just copy over some stuff...
Ben, there are a few places I just had to leave code un-commented to get it to compile (oddities with namespaces). Please have a look.
|
||
Comment 2•3 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #0)
I don't know what the long term solution should be. This file seems to keep accumulating old junk... To get Thunderbird building again I'll just copy over some stuff...
Sorry for breaking thunderbird build. I'm working with other i18n people in gecko to get rid of the old lwbrk breakers, which are outdated and not conforming to Unicode standards. The goal is to provide a set of unified segmenter API (bug 1684927) which is backed by ICU4X's segmenter.
|
||
Comment 3•3 years ago
|
||
Depends on D124991
|
|
||
Comment 4•3 years ago
|
||
I think that gets it back to how it was. Did I miss anything?
I've written up some breadcrumbs for a spring-cleaning followup: Bug 1729842.
|
Assignee | |
Comment 5•3 years ago
|
||
There was two un-commented cases left after the patch. I'll go ahead and fix those now (the unicode include makes them work)
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/25e83501d689
Restore word breaking for bayesian filter on SE Asian scripts without spaces. r=mkmelin
Description
•