1729728 - Undefined status of Troubleshoot mode in composition as menu always shows "Troubleshoot Mode..."

Status: VERIFIED FIXED

(Thunderbird :: General, defect, P3)

Description

[Thomas D. (:thomas8)]

Seen on 78, 93 beta, and Daily 94.0a1 (2021-09-08) (64-bit), Win10

STR

1. Help > Troubleshoot Mode (restart TB in TS mode)
2. Check Help menu in main 3-pane window for Troubleshoot status
3. Check Help menu in composition for Trobleshoot status

Actual

• in main 3-pane, correctly shows "Turn Troubleshoot Mode Off"
• in composition, wrongly shows "Troubleshoot Mode...", but we are supposed to be in Troubleshoot mode already, so the status is not clear - probably just the menu not updated, but the wrong menu suggests that Troubleshoot mode is not applied to composition...
• Ultimate confusion for support cases

Expected

• In composition, update the Troubleshoot menu entry according to the current Troubleshoot status. Perhaps double-check if troubleshoot mode is correctly applied to composition.

Comment 1

[Thomas D. (:thomas8)]

Alex, could you find someone to work on this? For enterprise support, we must have reliable indication of troubleshoot mode to avoid much confusion where the actual trouble shoot status differs from the advertised status in composition.

Comment 2

[Richard Marti (:Paenglab)]

The menu change is done here.

Affected are the stand-alone message window, the composer and the AB.

Comment 3

[Magnus Melin [:mkmelin]]

I guess that part of the code should move to mailCore.js, and each window that needs it should call it in onload.

Comment 4

[Alessandro Castellani [:aleca]]

Assigning this to Lasana. Let me know if you need any pointers.

Comment 5

[Lasana Murray]

Attachment: Bug 1729728 - Display correct troubleshooting mode menu item on all major windows. r=mkmelin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0c9749ff1dd3
Display correct troubleshooting mode menu item on all major windows. r=mkmelin

Comment 7

[Thomas D. (:thomas8)]

Thanks much Lasana for fixing this! (Verified on 96.0a1 (2021-11-09) (64-bit) for composition, AB, and standalone msg window)

Comment 8

[Thomas D. (:thomas8)]

Comment on attachment 9246537 [details]
Bug 1729728 - Display correct troubleshooting mode menu item on all major windows. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): ?
User impact if declined: Potential support confusion as active Troubleshoot mode isn't indicated in satellite windows
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low, moved updating of TS menus into central function and added some callers.

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9246537 [details]
Bug 1729728 - Display correct troubleshooting mode menu item on all major windows. r=mkmelin

[Triage Comment]
Approved for esr91

Comment 10

[Rob Lemley [:rjl]]

Comment on attachment 9246537 [details]
Bug 1729728 - Display correct troubleshooting mode menu item on all major windows. r=mkmelin

This patch will not work on c-esr91. Specifically, msgMail3PaneWindow.js is modifying the _loadComponentsAtStartup function, which is not present in Thunderbird 91. It was added in Bug 942615, and given its complexity I'm not sure it's feasible to uplift it.

I'll let you and :aleca work out how you want to proceed.

Comment 11

[Lasana Murray]

Attachment: Bug 1729728 - (esr-91-version) Display correct troubleshooting mode menu item on all major windows. r=aleca

Comment 12

[Alessandro Castellani [:aleca]]

Rob, the 91 patch works as expected.

Comment 13

[Lasana Murray]

Comment on attachment 9251023 [details]
Bug 1729728 - (esr-91-version) Display correct troubleshooting mode menu item on all major windows. r=aleca

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: ESR 91 will still show incorrect "Troubleshoot Mode" menu item
Testing completed (on c-c, etc.): esr-91
Risk to taking this patch (and alternatives if risky): None really, code contains minor change from trunk patch

Comment 14

[Rob Lemley [:rjl]]

Comment on attachment 9251023 [details]
Bug 1729728 - (esr-91-version) Display correct troubleshooting mode menu item on all major windows. r=aleca

[Triage Comment]
Previously approved by wsmwk (comment 9)

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 91.3.2:
https://hg.mozilla.org/releases/comm-esr91/rev/51d93efe0556