1729977 - White background into Dark theme into "From" dropdown when composing messages

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Eduardo Mozart de Oliveira]

Attachment: 2021-09-09 15_35_43-.png

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.63 Safari/537.36

Steps to reproduce:

1. Open Thunderbird.
2. Reply or compose a new message.

Actual results:

The "From" dropdown shows a White background and white fontcolor so it's not possible to see the accounts from dropdown.

Expected results:

The "From" dropdown should show a Black background and white fontcolor into dropdown so it would be possible to see the accounts from dropdown when using Dark Thunderbird theme.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1729977-msgIdentityPopup-color.patch

Alessandro, you can test this on Windows 10 with setting browser.display.windows.non_native_menus to 0.

Comment 2

[Eduardo Mozart de Oliveira]

I tried to apply this fix into userChrome.css file but the issue persists into my system (Windows 7 x64). Tried to change the setting browser.display.windows.non_native_menus and it didn't worked neither. I tried to change the "transparent" keyword to "black" but no avail.

Comment 3

[Richard Marti (:Paenglab)]

In userChrome.css you need to try with !important added. Here my build works on Win7 Basic.

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9240570 [details] [diff] [review]
1729977-msgIdentityPopup-color.patch

Review of attachment 9240570 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 5

[Eduardo Mozart de Oliveira]

Into my setup (Win7 Pro x64/Thunderbird 91), it didn't worked into userChrome.css, even with the ''important'' flag appended. The ''browser.display.windows.non_native_menus'' property was set to "2", I tried changing it to "0" and restarting Thunderbird 91, but the issue persisted.

I had to remove ":root[lwt-tree] " in front of element so it started working.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/efe2bf7d4803
[Windows] Set the msgIdentityPopup background color with native menus. r=aleca

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 9240570 [details] [diff] [review]
1729977-msgIdentityPopup-color.patch

[Approval Request Comment]
User impact if declined: on Windows 7 with dark theme unreadable content in msgIdentityPopup
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9240570 [details] [diff] [review]
1729977-msgIdentityPopup-color.patch

[Triage Comment]
approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 93.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/11ab0ee3d549

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9240570 [details] [diff] [review]
1729977-msgIdentityPopup-color.patch

[Triage Comment]
Approved for esr91

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 91.1.1:
https://hg.mozilla.org/releases/comm-esr91/rev/d109fc1b358e