Closed Bug 1729977 Opened 11 months ago Closed 11 months ago

White background into Dark theme into "From" dropdown when composing messages

Categories

(Thunderbird :: Message Compose Window, defect)

Thunderbird 91
Desktop
Windows
defect

Tracking

(thunderbird_esr91? fixed, thunderbird93? fixed)

RESOLVED FIXED
94 Branch
Tracking Status
thunderbird_esr91 ? fixed
thunderbird93 ? fixed

People

(Reporter: eduardomozart182, Assigned: Paenglab)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.63 Safari/537.36

Steps to reproduce:

  1. Open Thunderbird.
  2. Reply or compose a new message.

Actual results:

The "From" dropdown shows a White background and white fontcolor so it's not possible to see the accounts from dropdown.

Expected results:

The "From" dropdown should show a Black background and white fontcolor into dropdown so it would be possible to see the accounts from dropdown when using Dark Thunderbird theme.

Alessandro, you can test this on Windows 10 with setting browser.display.windows.non_native_menus to 0.

Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9240570 - Flags: review?(alessandro)

I tried to apply this fix into userChrome.css file but the issue persists into my system (Windows 7 x64). Tried to change the setting browser.display.windows.non_native_menus and it didn't worked neither. I tried to change the "transparent" keyword to "black" but no avail.

In userChrome.css you need to try with !important added. Here my build works on Win7 Basic.

Blocks: tb91found
Keywords: regression
OS: Unspecified → Windows
Hardware: Unspecified → Desktop
Comment on attachment 9240570 [details] [diff] [review]
1729977-msgIdentityPopup-color.patch

Review of attachment 9240570 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Attachment #9240570 - Flags: review?(alessandro) → review+
Target Milestone: --- → 94 Branch

Into my setup (Win7 Pro x64/Thunderbird 91), it didn't worked into userChrome.css, even with the ''important'' flag appended. The ''browser.display.windows.non_native_menus'' property was set to "2", I tried changing it to "0" and restarting Thunderbird 91, but the issue persisted.

I had to remove ":root[lwt-tree] " in front of element so it started working.

Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/efe2bf7d4803
[Windows] Set the msgIdentityPopup background color with native menus. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED

Comment on attachment 9240570 [details] [diff] [review]
1729977-msgIdentityPopup-color.patch

[Approval Request Comment]
User impact if declined: on Windows 7 with dark theme unreadable content in msgIdentityPopup
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9240570 - Flags: approval-comm-esr91?
Attachment #9240570 - Flags: approval-comm-beta?

Comment on attachment 9240570 [details] [diff] [review]
1729977-msgIdentityPopup-color.patch

[Triage Comment]
approved for beta

Attachment #9240570 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9240570 [details] [diff] [review]
1729977-msgIdentityPopup-color.patch

[Triage Comment]
Approved for esr91

Attachment #9240570 - Flags: approval-comm-esr91? → approval-comm-esr91+
You need to log in before you can comment on or make changes to this bug.