Closed Bug 1730066 Opened 3 months ago Closed 2 months ago

Enable tab unloading on macOS

Categories

(Firefox :: Tabbed Browser, enhancement)

Desktop
macOS
enhancement

Tracking

()

VERIFIED FIXED
95 Branch
Tracking Status
firefox95 --- verified

People

(Reporter: haik, Assigned: haik)

References

Details

Attachments

(1 file)

This bug is to enable tab unloading on macOS. Bug 1587762 enabled tab unloading for Windows. On Mac, with bug 1714382 we started listening for OS memory pressure events on macOS and including the memory pressure state in crash reports and event pings (bug 1723604).

This bug is filed to cover enabling tab unloading and the memory-pressure Gecko notification on low memory.

Assignee: nobody → haftandilian

Enable tab unloading on macOS when the OS memory pressure level reaches "critical".

Add a gtest that exercises the memory pressure response by testing that a tab unload attempt occurs and the internal memory-pressure notification is sent. Test does not cause a real OS memory pressure event.

Use the memory_pressure(1) macOS command to generate artificial memory pressure events to test the browser response. For example, the following artificially puts the OS in the "critical" memory pressure level for 60 seconds.

$ sudo memory_pressure -S -l critical -s 60

Pushed by haftandilian@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3ad47305d04
Enable tab unloading on macOS r=spohl
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

This enhancement was part of the work done on QA-1196 "Tab Unloading in Nightly 95" bugwork.
Considering the above, I'm marking this enhancement as Verified.

Status: RESOLVED → VERIFIED

We mentioned tab unloading for windows as a new feature in Firefox 93 release notes, should this one be mentioned in Firefox 95 release notes? Thanks.

Flags: needinfo?(haftandilian)

(In reply to Pascal Chevrel:pascalc from comment #5)

We mentioned tab unloading for windows as a new feature in Firefox 93 release notes, should this one be mentioned in Firefox 95 release notes? Thanks.

No, it's not riding the trains yet.

Flags: needinfo?(haftandilian)

(In reply to Haik Aftandilian [:haik] from comment #6)

(In reply to Pascal Chevrel:pascalc from comment #5)

We mentioned tab unloading for windows as a new feature in Firefox 93 release notes, should this one be mentioned in Firefox 95 release notes? Thanks.

No, it's not riding the trains yet.

OK, then it should be mentioned on our Nightly release notes :)

Flags: needinfo?(haftandilian)

(In reply to Pascal Chevrel:pascalc from comment #7)

(In reply to Haik Aftandilian [:haik] from comment #6)

(In reply to Pascal Chevrel:pascalc from comment #5)

We mentioned tab unloading for windows as a new feature in Firefox 93 release notes, should this one be mentioned in Firefox 95 release notes? Thanks.

No, it's not riding the trains yet.

OK, then it should be mentioned on our Nightly release notes :)

Ah 95 release notes, yes. Thanks!

Flags: needinfo?(haftandilian)
You need to log in before you can comment on or make changes to this bug.