Closed Bug 1730090 Opened 3 years ago Closed 2 years ago

TextLeafPoint: Implement BOUNDARY_PARAGRAPH

Categories

(Core :: Disability Access APIs, task)

task

Tracking

()

RESOLVED FIXED
99 Branch
Tracking Status
firefox99 --- fixed

People

(Reporter: Jamie, Assigned: Jamie)

References

Details

(Whiteboard: [ctw-m1])

Attachments

(1 file, 4 obsolete files)

TextLeafPoint::FindBoundary needs to support BOUNDARY_PARAGRAPH. This should be fairly similar to the paragraph code in HyperTextAccessible, since it already crawls the a11y tree (it doesn't use layout).

No longer blocks: a11y-ctw
Depends on: 1743968
Whiteboard: [ctw-m1]

This information is already available via Attributes, but we don't want to retrieve all Attributes just to get the display style.

Assignee: nobody → jteh
Status: NEW → ASSIGNED

This is achieved via a new FILTER_WALK_SUBTREE_IF_CONTAINS_ANCHOR which is combined with FILTER_IGNORE_SUBTREE.
This is necessary when searching for a paragraph boundary, since we want to find a containing block but we don't want to descend into other blocks.

Blocks: 1755420
Attachment #9263881 - Attachment is obsolete: true
Attachment #9263882 - Attachment is obsolete: true
Attachment #9263883 - Attachment is obsolete: true
Depends on: 1755604

Comment on attachment 9263885 [details]
Bug 1730090 alternative part 2: Add Accessible::IsBefore/IsAncestorOf.

Revision D138743 was moved to bug 1755604. Setting attachment 9263885 [details] to obsolete.

Attachment #9263885 - Attachment is obsolete: true
Attachment #9263886 - Attachment description: Bug 1730090 alternative part 3: Implement support for BOUNDARY_PARAGRAPH in TextLeafPoint and HyperTextAccessibleBase. → Bug 1730090: Implement support for BOUNDARY_PARAGRAPH in TextLeafPoint and HyperTextAccessibleBase.
Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b3360b57cf38
Implement support for BOUNDARY_PARAGRAPH in TextLeafPoint and HyperTextAccessibleBase. r=eeejay

Backed out 4 changesets (bug 1730090, bug 1755604, bug 1755420) for causing build bustages in accessible/base/TextLeafRange.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/6938c3b26d145c7e2c77f078566463df66d45359

Push with failures

Failure log

NFO -  In file included from Unified_cpp_accessible_base1.cpp:29:
[task 2022-02-18T06:06:16.637Z] 06:06:16    ERROR -  /builds/worker/checkouts/gecko/accessible/base/TextLeafRange.cpp:361:15: error: expected unqualified-id
[task 2022-02-18T06:06:16.637Z] 06:06:16     INFO -      if (RefPtr{aAcc->DisplayStyle()} == nsGkAtoms::block ||
Flags: needinfo?(jteh)
Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a59c38e062bd
Implement support for BOUNDARY_PARAGRAPH in TextLeafPoint and HyperTextAccessibleBase. r=eeejay
Flags: needinfo?(jteh)
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: