1755604 - Add IsBefore and IsAncestorOf methods to Accessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

To search for paragraph boundaries, we need Accessible::IsAncestorOf. I originally thought we'd need IsBefore as well, but it turns out we don't. Still, I think it's useful and we already use that code in TextLeafPoint.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1755604: Add Accessible::IsBefore/IsAncestorOf.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3fb940c71b19
Add Accessible::IsBefore/IsAncestorOf. r=eeejay

Comment 3

[Sandor Molnar[:smolnar]]

Backed out 4 changesets (bug 1730090, bug 1755604, bug 1755420) for causing build bustages in accessible/base/TextLeafRange.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/6938c3b26d145c7e2c77f078566463df66d45359

Push with failures

Failure log

NFO -  In file included from Unified_cpp_accessible_base1.cpp:29:
[task 2022-02-18T06:06:16.637Z] 06:06:16    ERROR -  /builds/worker/checkouts/gecko/accessible/base/TextLeafRange.cpp:361:15: error: expected unqualified-id
[task 2022-02-18T06:06:16.637Z] 06:06:16     INFO -      if (RefPtr{aAcc->DisplayStyle()} == nsGkAtoms::block ||

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5663402b5f2
Add Accessible::IsBefore/IsAncestorOf. r=eeejay

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b5663402b5f2