Closed Bug 1755604 Opened 2 years ago Closed 2 years ago

Add IsBefore and IsAncestorOf methods to Accessible

Categories

(Core :: Disability Access APIs, task)

task

Tracking

()

RESOLVED FIXED
99 Branch
Tracking Status
firefox99 --- fixed

People

(Reporter: Jamie, Assigned: Jamie)

References

Details

Attachments

(1 file)

To search for paragraph boundaries, we need Accessible::IsAncestorOf. I originally thought we'd need IsBefore as well, but it turns out we don't. Still, I think it's useful and we already use that code in TextLeafPoint.

Attachment #9264082 - Attachment description: Bug 1730090 alternative part 2: Add Accessible::IsBefore/IsAncestorOf. → Bug 1755604: Add Accessible::IsBefore/IsAncestorOf.
Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3fb940c71b19
Add Accessible::IsBefore/IsAncestorOf. r=eeejay

Backed out 4 changesets (bug 1730090, bug 1755604, bug 1755420) for causing build bustages in accessible/base/TextLeafRange.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/6938c3b26d145c7e2c77f078566463df66d45359

Push with failures

Failure log

NFO -  In file included from Unified_cpp_accessible_base1.cpp:29:
[task 2022-02-18T06:06:16.637Z] 06:06:16    ERROR -  /builds/worker/checkouts/gecko/accessible/base/TextLeafRange.cpp:361:15: error: expected unqualified-id
[task 2022-02-18T06:06:16.637Z] 06:06:16     INFO -      if (RefPtr{aAcc->DisplayStyle()} == nsGkAtoms::block ||
Flags: needinfo?(jteh)
Flags: needinfo?(jteh)
Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b5663402b5f2
Add Accessible::IsBefore/IsAncestorOf. r=eeejay
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: