1730093 - Cache text and line offsets

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

When sending cache data for a subtree, we need to send the text of TextLeafAccessibles, as well as line offsets. We also need to do this when a text leaf is updated (which is handled by TextUpdater). TextLeafPoint and HyperTextAccessible need to be taught how to use that cached data.

Comment 1

[James Teh [:Jamie]]

We might already cache the text of TextLeafAccessibles with the name caching implemented in bug 1700264. However, if we do, we wouldn't be keeping it up to date, as TextLeafAccessibles don't (and shouldn't) fire name change events.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1730093 part 1: Push text and line start offsets to the cache.

As part of this, we no longer cache the name for text accessibles, as that would be redundant.
Instead, we return the cached text in RemoteAccessible::Name.

Comment 3

[James Teh [:Jamie]]

Attachment: Bug 1730093 part 2: Move AppendTextTo to Accessible and implement it for RemoteAccessible.

Comment 4

[James Teh [:Jamie]]

Attachment: Bug 1730093 part 3: Support RemoteAccessible in nsAccUtils::TextLength.

Comment 5

[James Teh [:Jamie]]

Attachment: Bug 1730093 part 4: Support RemoteAccessible in TextLeafPoint.

This uses the unified AppendTextTo and TextLength, as well as adding support for cached line start boundaries.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/593b86a95509
part 1: Push text and line start offsets to the cache. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/e89a1d6424f7
part 2: Move AppendTextTo to Accessible and implement it for RemoteAccessible. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/98e556a28416
part 3: Support RemoteAccessible in nsAccUtils::TextLength. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/83bcd4379c5e
part 4: Support RemoteAccessible in TextLeafPoint. r=eeejay

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/593b86a95509
https://hg.mozilla.org/mozilla-central/rev/e89a1d6424f7
https://hg.mozilla.org/mozilla-central/rev/98e556a28416
https://hg.mozilla.org/mozilla-central/rev/83bcd4379c5e