1731154 - Make AccAttributes entries movable and avoid copies.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Eitan Isaacson [:eeejay]]

We currently need to use copyable arrays in AccAttributes. We should be avoiding copies and using references and moves whenever possible.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1731154 - Add move semantics to AccAttributes and use value references to avoid copies. r?morgan

Changed the array type to nsTArray to avoid copies and get compile-time
errors if we ever try to do that. To set an array as a value, it must be
moved.

Comment 2

[Morgan Reschenberg [:morgan]]

Changing severity to P1/S3 for triage

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/176469dcdeba
Add move semantics to AccAttributes and use value references to avoid copies. r=morgan

Comment 4

[Marian-Vasile Laza]

Backed out changeset 176469dcdeba (Bug 1731154) for causing bc failures on browser_attributed_text.js.
Backout link
Push with failures - bc4
Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/003ef3c8730c
Add move semantics to AccAttributes and use value references to avoid copies. r=morgan

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/003ef3c8730c