`Expand List` merges preceding error pill `John` (without @) with first address from mailing list, which becomes invalid
Categories
(Thunderbird :: Message Compose Window, defect, P3)
Tracking
(thunderbird_esr91+ fixed, thunderbird93+ fixed)
People
(Reporter: thomas8, Assigned: mkmelin)
Details
Attachments
(3 files)
62.96 KB,
image/png
|
Details | |
48 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr91+
|
Details | Review |
48 bytes,
text/x-phabricator-request
|
Details | Review |
It's a bit of an edge case, but merging an unrelated error pill into the first address expanded from a mailing list is quite odd and hard to discover when it happens.
STR
- compose, add an incomplete address without @ (say you still need to find John's address, but you want to add a placeholder to remind yourself):
John
- Add a mailing list (ML) pill containing
foo@bar.com
andbar@baz.com
- From ML pill context,
Expand List
Actual result
- Error pill is gone
- unfinished address of error pill merged into first expanded address (or whichever address was following the error pill while expanding the list somewhere in the same field), invalidating the neighboring address in the process:
John,foo@bar.com <foo@bar.com>
Expected
- Leave the error pill alone
- Don't merge unrelated pills when expanding mailing list
We must be doing something wrong here, because the same does not happen for copy and paste including such invalid pill (which currently also goes through a plaintext stage).
Reporter | ||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
This only worked by accident: makeFromDisplayAddress should be called on each address, not the toString() represenation of the array.
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/141604e05870
fix list expansion in combination with invalid pills. r=lasana
Comment 5•3 years ago
|
||
And now it fails where an element of addressArray
has multiple addresses, for example if you drag contacts from the address book.
Comment 6•3 years ago
|
||
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/d302a27401de follow-up - Fix dragging multiple addresses to the compose window. r=aleca
Comment 8•3 years ago
|
||
Comment on attachment 9240885 [details]
Bug 1730363 - fix list expansion in combination with invalid pills. r=lasana
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: error pills interact oddly with mailing list pills
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
looks safe for beta
Comment 9•3 years ago
|
||
Comment on attachment 9240885 [details]
Bug 1730363 - fix list expansion in combination with invalid pills. r=lasana
[Triage Comment]
approved for beta
Comment 10•3 years ago
|
||
bugherder uplift |
Thunderbird 93.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/1e44cd1fc2f7
https://hg.mozilla.org/releases/comm-beta/rev/5ee0f2f00dcb
Assignee | ||
Comment 11•3 years ago
|
||
Comment on attachment 9240885 [details]
Bug 1730363 - fix list expansion in combination with invalid pills. r=lasana
[Approval Request Comment]
Regression caused by (bug #): not a regression
User impact if declined: per bug summary
Testing completed (on c-c, etc.): c-c, beta
Risk to taking this patch (and alternatives if risky): low
Comment 12•3 years ago
|
||
Comment on attachment 9240885 [details]
Bug 1730363 - fix list expansion in combination with invalid pills. r=lasana
[Triage Comment]
Approved for esr91
Comment 13•3 years ago
|
||
Could I get an esr91 version of this fix for uplift?
Assignee | ||
Comment 14•3 years ago
|
||
ESR91 version: https://hg.mozilla.org/try-comm-central/rev/768be37514209b2a03924181886a33570449876c
Try going at https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=bed8aa848f4f82a9440555476aa24a0dda40afaa
Comment 15•3 years ago
|
||
Thunderbird 91.2.1:
https://hg.mozilla.org/releases/comm-esr91/rev/7191605fac12fab164c4499af7fd734601ac9393
Comment 16•3 years ago
|
||
Thunderbird 91.2.1 (follow-up):
https://hg.mozilla.org/releases/comm-esr91/rev/82a7046d27bdfcfb983922e7d203564069d9a6e2
Description
•