Closed Bug 1730397 Opened 3 years ago Closed 3 years ago

firefox-91.1.0 fails to compile with rust-1.56

Tracking

(firefox-esr91 fixed, firefox94 fixed)

Status:

RESOLVED FIXED

Milestone:

94 Branch

Tracking Flags:

Tracking

Status

firefox-esr91

---

fixed

firefox94

---

fixed

People

(Reporter: herrtimson, Assigned: glandium)

References

Details

Attachments

(6 files)

firefox-91.1.0-with-rust-1.56.0.log.xz 3 years ago tt_1 185.33 KB, application/x-xz		Details
firefox-91.1-with-updated-packed-simd.log.xz 3 years ago tt_1 131.62 KB, application/x-xz		Details
Bug 1730397 - Remove unnecessary semi-colons in some macros. 3 years ago Mike Hommey [:glandium] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1730397 - Apply prost-derive fix for function name collision. 3 years ago Mike Hommey [:glandium] 48 bytes, text/x-phabricator-request	RyanVM : approval-mozilla-esr91+	Details \| Review
Bug 1730397 - Fix unstable-name-collisions in mio. 3 years ago Mike Hommey [:glandium] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1730397 - Update packed_simd to a version that supports rustc >= 1.56. 3 years ago Mike Hommey [:glandium] 48 bytes, text/x-phabricator-request	RyanVM : approval-mozilla-esr91+	Details \| Review

tt_1

Reporter

Description

•

3 years ago

Attached file firefox-91.1.0-with-rust-1.56.0.log.xz — Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

hey there, I installed rust-1.56-beta2 for testing and tried to compile firefox with it on a linux amd64 box. The compile is broken.

Actual results:

the compile failed with these errors:

1:56.73 error: [u32; 2] is forbidden as the type of a const generic parameter
1:56.73 --> /var/tmp/portage/www-client/firefox-91.1.0/work/firefox-91.1.0/third_party/rust/packed_simd/src/codegen/llvm.rs:20:44
1:56.73 |
1:56.73 20 | pub unsafe fn __shuffle_vector2<const IDX: [u32; 2], T, U>(x: T, y: T) -> U
1:56.73 | ^^^^^^^^
1:56.73 |
1:56.73 = note: the only supported types are integers, bool and char
1:56.73 = help: more complex types are supported with #![feature(adt_const_params)]
1:56.73 error: [u32; 4] is forbidden as the type of a const generic parameter
1:56.73 --> /var/tmp/portage/www-client/firefox-91.1.0/work/firefox-91.1.0/third_party/rust/packed_simd/src/codegen/llvm.rs:30:44
1:56.73 |
1:56.73 30 | pub unsafe fn __shuffle_vector4<const IDX: [u32; 4], T, U>(x: T, y: T) -> U
1:56.73 | ^^^^^^^^
1:56.73 |
1:56.73 = note: the only supported types are integers, bool and char
1:56.73 = help: more complex types are supported with #![feature(adt_const_params)]
1:56.73 error: [u32; 8] is forbidden as the type of a const generic parameter
1:56.73 --> /var/tmp/portage/www-client/firefox-91.1.0/work/firefox-91.1.0/third_party/rust/packed_simd/src/codegen/llvm.rs:40:44
1:56.73 |
1:56.73 40 | pub unsafe fn __shuffle_vector8<const IDX: [u32; 8], T, U>(x: T, y: T) -> U
1:56.73 | ^^^^^^^^
1:56.73 |
1:56.73 = note: the only supported types are integers, bool and char
1:56.73 = help: more complex types are supported with #![feature(adt_const_params)]
1:56.73 error: [u32; 16] is forbidden as the type of a const generic parameter
1:56.73 --> /var/tmp/portage/www-client/firefox-91.1.0/work/firefox-91.1.0/third_party/rust/packed_simd/src/codegen/llvm.rs:50:45
1:56.73 |
1:56.73 50 | pub unsafe fn __shuffle_vector16<const IDX: [u32; 16], T, U>(x: T, y: T) -> U
1:56.73 | ^^^^^^^^^
1:56.73 |
1:56.73 = note: the only supported types are integers, bool and char
1:56.73 = help: more complex types are supported with #![feature(adt_const_params)]
1:56.73 error: [u32; 32] is forbidden as the type of a const generic parameter
1:56.73 --> /var/tmp/portage/www-client/firefox-91.1.0/work/firefox-91.1.0/third_party/rust/packed_simd/src/codegen/llvm.rs:60:45
1:56.73 |
1:56.73 60 | pub unsafe fn __shuffle_vector32<const IDX: [u32; 32], T, U>(x: T, y: T) -> U
1:56.73 | ^^^^^^^^^
1:56.73 |
1:56.73 = note: the only supported types are integers, bool and char
1:56.73 = help: more complex types are supported with #![feature(adt_const_params)]
1:56.73 error: [u32; 64] is forbidden as the type of a const generic parameter
1:56.74 --> /var/tmp/portage/www-client/firefox-91.1.0/work/firefox-91.1.0/third_party/rust/packed_simd/src/codegen/llvm.rs:70:45
1:56.74 |
1:56.74 70 | pub unsafe fn __shuffle_vector64<const IDX: [u32; 64], T, U>(x: T, y: T) -> U
1:56.74 | ^^^^^^^^^
1:56.74 |
1:56.74 = note: the only supported types are integers, bool and char
1:56.74 = help: more complex types are supported with #![feature(adt_const_params)]

Expected results:

compile should have passed

I will attach the compressed build log, as of now I was unable to find a specific rust pullrequst that broke this.

tt_1

Reporter

Comment 1

•

3 years ago

It seems I wasn't grepping correctly, here are some missing but interesting bits:

1:52.57 error[E0557]: feature has been removed
1:52.57 --> /var/tmp/portage/www-client/firefox-91.1.0/work/firefox-91.1.0/third_party/rust/packed_simd/src/lib.rs:203:5
1:52.57 |
1:52.57 203 | const_generics,
1:52.57 | ^^^^^^^^^^^^^^ feature has been removed
1:52.57 |

1:55.31 mkdir -p '.deps/'
1:55.31 caps/BasePrincipal.o

1:54.80 error: type parameters must be declared prior to const parameters
1:54.80 --> /var/tmp/portage/www-client/firefox-91.1.0/work/firefox-91.1.0/third_party/rust/packed_simd/src/codegen/llvm.rs:20:54
1:54.80 |
1:54.80 20 | pub unsafe fn __shuffle_vector2<const IDX: [u32; 2], T, U>(x: T, y: T) -> U
1:54.80 | ----------------------^--^- help: reorder the parameters: lifetimes, then types, then consts: <T, U, const IDX: [u32; 2]>
1:54.80 error: type parameters must be declared prior to const parameters
1:54.80 --> /var/tmp/portage/www-client/firefox-91.1.0/work/firefox-91.1.0/third_party/rust/packed_simd/src/codegen/llvm.rs:30:54
1:54.81 |
1:54.81 30 | pub unsafe fn __shuffle_vector4<const IDX: [u32; 4], T, U>(x: T, y: T) -> U
1:54.81 | ----------------------^--^- help: reorder the parameters: lifetimes, then types, then consts: <T, U, const IDX: [u32; 4]>
1:54.81 error: type parameters must be declared prior to const parameters
1:54.81 --> /var/tmp/portage/www-client/firefox-91.1.0/work/firefox-91.1.0/third_party/rust/packed_simd/src/codegen/llvm.rs:40:54
1:54.81 |
1:54.81 40 | pub unsafe fn __shuffle_vector8<const IDX: [u32; 8], T, U>(x: T, y: T) -> U
1:54.81 | ----------------------^--^- help: reorder the parameters: lifetimes, then types, then consts: <T, U, const IDX: [u32; 8]>
1:54.81 error: type parameters must be declared prior to const parameters
1:54.81 --> /var/tmp/portage/www-client/firefox-91.1.0/work/firefox-91.1.0/third_party/rust/packed_simd/src/codegen/llvm.rs:50:56
1:54.81 |
1:54.81 50 | pub unsafe fn __shuffle_vector16<const IDX: [u32; 16], T, U>(x: T, y: T) -> U
1:54.81 | -----------------------^--^- help: reorder the parameters: lifetimes, then types, then consts: <T, U, const IDX: [u32; 16]>
1:54.81 error: type parameters must be declared prior to const parameters
1:54.81 --> /var/tmp/portage/www-client/firefox-91.1.0/work/firefox-91.1.0/third_party/rust/packed_simd/src/codegen/llvm.rs:60:56
1:54.81 |
1:54.81 60 | pub unsafe fn __shuffle_vector32<const IDX: [u32; 32], T, U>(x: T, y: T) -> U
1:54.81 | -----------------------^--^- help: reorder the parameters: lifetimes, then types, then consts: <T, U, const IDX: [u32; 32]>
1:54.81 error: type parameters must be declared prior to const parameters
1:54.81 --> /var/tmp/portage/www-client/firefox-91.1.0/work/firefox-91.1.0/third_party/rust/packed_simd/src/codegen/llvm.rs:70:56
1:54.81 |
1:54.81 70 | pub unsafe fn __shuffle_vector64<const IDX: [u32; 64], T, U>(x: T, y: T) -> U
1:54.81 | -----------------------^--^- help: reorder the parameters: lifetimes, then types, then consts: <T, U, const IDX: [u32; 64]>
1:54.93 Compiling fallible_collections v0.4.2

tt_1

Reporter

Comment 2

•

3 years ago

so this is solved upstream:

https://github.com/rust-lang/packed_simd/commit/45d5347a0d2187c046a546a477d2a53111cd7713

maybe consider to cherry pick it?

BugBot [:suhaib / :marco/ :calixte]

Comment 3

•

3 years ago

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::General' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → General

Product: Firefox → Firefox Build System

tt_1

Reporter

Comment 4

•

3 years ago

Attached file firefox-91.1-with-updated-packed-simd.log.xz — Details

I pulled in the packed-simd update locally (need to refresh checksums), this uncovers another error. Upstream issue: https://github.com/tokio-rs/prost/issues/526

3:09.40 error[E0034]: multiple applicable items in scope
3:09.40 --> /var/tmp/portage/www-client/firefox-91.1.0/work/firefox-91.1.0/third_party/rust/prost-derive/src/lib.rs:111:14
3:09.40 |
3:09.40 111 | .intersperse(quote!(|));
3:09.40 | ^^^^^^^^^^^ multiple intersperse found
3:09.40 |
3:09.40 = note: candidate #1 is defined in an impl of the trait Iterator for the type Map<I, F>
3:09.40 = note: candidate #2 is defined in an impl of the trait Itertools for the type T
3:09.40 help: disambiguate the associated function for candidate #1
3:09.40 |
3:09.40 107 ~ let tags = Iterator::intersperse(field
3:09.40 108 + .tags()
3:09.40 109 + .into_iter()
3:09.40 110 + .map(|tag| quote!(#tag)), {
3:09.40 111 + let mut _s = $crate::__private::TokenStream::new();
3:09.40 112 + $crate::quote_each_token!(_s $($tt));
3:09.40 ...
3:09.40 help: disambiguate the associated function for candidate #2
3:09.40 |
3:09.40 107 ~ let tags = Itertools::intersperse(field
3:09.40 108 + .tags()
3:09.40 109 + .into_iter()
3:09.40 110 + .map(|tag| quote!(#tag)), {
3:09.40 111 + let mut _s = $crate::__private::TokenStream::new();
3:09.40 112 + $crate::quote_each_token!(_s $($tt));
3:09.40 ...
3:09.48 warning: unused import: itertools::Itertools
3:09.48 --> /var/tmp/portage/www-client/firefox-91.1.0/work/firefox-91.1.0/third_party/rust/prost-derive/src/lib.rs:11:5
3:09.48 |
3:09.48 11 | use itertools::Itertools;
3:09.48 | ^^^^^^^^^^^^^^^^^^^^
3:09.48 |
3:09.48 = note: #[warn(unused_imports)] on by default
3:09.48 For more information about this error, try rustc --explain E0034.
3:09.49 warning: prost-derive (lib) generated 1 warning
3:09.49 error: could not compile prost-derive due to previous error; 1 warning emitted

compressed log is attached

Mitchell Hentges [:mhentges] 🦀

Updated

•

3 years ago

Priority: -- → P3

Mitchell Hentges [:mhentges] 🦀

Comment 5

•

3 years ago

packed_simd_2 0.3.6 is out as of Sept 9th, which will make that update easier, good find tt.
I'll keep an eye on that prost issue.

Mike Hommey [:glandium]

Assignee

Comment 6

•

3 years ago

We're not using packed_simd_2, we're using a fork. And the upstream change will break building with older versions.

Mike Hommey [:glandium]

Assignee

Comment 7

•

3 years ago

PR for packed_simd: https://github.com/hsivonen/packed_simd/pull/2

Mike Hommey [:glandium]

Assignee

Comment 8

•

3 years ago

Attached file Bug 1730397 - Remove unnecessary semi-colons in some macros. — Details

Phabricator Automation

Updated

•

3 years ago

Assignee: nobody → mh+mozilla

Mike Hommey [:glandium]

Assignee

Comment 9

•

3 years ago

Attached file Bug 1730397 - Apply prost-derive fix for function name collision. — Details

This applies https://github.com/tokio-rs/prost/commit/edb1464b71528286a6ce74278af05f19c3e0e820
to our copy of prost 0.6.1.

Mike Hommey [:glandium]

Assignee

Comment 10

•

3 years ago

Attached file Bug 1730397 - Fix unstable-name-collisions in mio. — Details

Our copy of mio is already self-vendored, so we don't need a Cargo.toml
change to be able to apply in-tree changes.

Mike Hommey [:glandium]

Assignee

Comment 11

•

3 years ago

Attached file Bug 1730397 - Update packed_simd to a version that supports rustc >= 1.56. — Details

Pulsebot

Comment 12

•

3 years ago

Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/7ade904df34a
Remove unnecessary semi-colons in some macros. r=emilio
https://hg.mozilla.org/integration/autoland/rev/1f96f89c6fc8
Apply prost-derive fix for function name collision. r=emilio
https://hg.mozilla.org/integration/autoland/rev/0a7c0bdb2c19
Fix unstable-name-collisions in mio. r=emilio
https://hg.mozilla.org/integration/autoland/rev/9af854b99136
Update packed_simd to a version that supports rustc >= 1.56. r=hsivonen

Marian-Vasile Laza

Comment 13

•

3 years ago

•

Edited

Backed out changeset 9af854b99136 (Bug 1730397) as requested by the dev for causing SM bustages.
Backout link
Push with failures
Failure Log

Flags: needinfo?(mh+mozilla)

Marian-Vasile Laza

Updated

•

3 years ago

Keywords: leave-open

Mike Hommey [:glandium]

Assignee

Comment 14

•

3 years ago

We'll need a more fine-grained test in packed_simd.

Flags: needinfo?(mh+mozilla)

Mike Hommey [:glandium]

Assignee

Updated

•

3 years ago

Depends on: 1730851

Marian-Vasile Laza

Comment 15

•

3 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/7ade904df34a
https://hg.mozilla.org/mozilla-central/rev/1f96f89c6fc8
https://hg.mozilla.org/mozilla-central/rev/0a7c0bdb2c19

Mike Hommey [:glandium]

Assignee

Updated

•

3 years ago

Keywords: leave-open

Mitchell Hentges [:mhentges] 🦀

Comment 16

•

3 years ago

Looks like a new release of prost is out that fixes the issue - though, it may introduce new ones until 0.9 is out.

Pulsebot

Comment 17

•

3 years ago

Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/74e579530088
Update packed_simd to a version that supports rustc >= 1.56. r=hsivonen

Cristian Tuns

Comment 18

•

3 years ago

Backed out as requested by Glandium.

Backout link

Flags: needinfo?(mh+mozilla)

Mike Hommey [:glandium]

Assignee

Updated

•

3 years ago

Flags: needinfo?(mh+mozilla)

Pulsebot

Comment 19

•

3 years ago

Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/ad06d68fed2c
Update packed_simd to a version that supports rustc >= 1.56. r=hsivonen

Marian-Vasile Laza

Comment 20

•

3 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/ad06d68fed2c

Status: UNCONFIRMED → RESOLVED

Closed: 3 years ago

status-firefox94: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 94 Branch

tt_1

Reporter

Comment 21

•

3 years ago

since this seems to stick, can I ask here for the backports to the esr91 branch?

Mike Hommey [:glandium]

Assignee

Comment 22

•

3 years ago

Comment on attachment 9241059 [details]
Bug 1730397 - Apply prost-derive fix for function name collision.

ESR Uplift Approval Request

If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build failure with rust 1.56.
User impact if declined: See above
Fix Landed on Version: 94
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): Trivial rust fixes. We don't need all the patches for a default build, though. The remaining ones only matter for --enable-warnings-as-errors, which we recommend not using.
String or UUID changes made by this patch:

Attachment #9241059 - Flags: approval-mozilla-esr91?

Mike Hommey [:glandium]

Assignee

Updated

•

3 years ago

Attachment #9241223 - Flags: approval-mozilla-esr91?

Ryan VanderMeulen [:RyanVM]

Comment 23

•

3 years ago

Comment on attachment 9241059 [details]
Bug 1730397 - Apply prost-derive fix for function name collision.

Approved for 91.2esr.

Attachment #9241059 - Flags: approval-mozilla-esr91? → approval-mozilla-esr91+

Ryan VanderMeulen [:RyanVM]

Updated

•

3 years ago

Attachment #9241223 - Flags: approval-mozilla-esr91? → approval-mozilla-esr91+

Ryan VanderMeulen [:RyanVM]

Comment 24

•

3 years ago

bugherder uplift

https://hg.mozilla.org/releases/mozilla-esr91/rev/e77ed5b5ed8b
https://hg.mozilla.org/releases/mozilla-esr91/rev/e5a5b3cbb30e

status-firefox-esr91: --- → fixed

tt_1

Reporter

Comment 25

•

3 years ago

thanks, can confirm working compile with rustc-1.56-beta3

there will be no backport to 93.0, no?

Mike Hommey [:glandium]

Assignee

Comment 26

•

3 years ago

Rust 1.56 is due to release after Firefox 93, so I figured it's not worth. Firefox 94 will be out just a few weeks after rust 1.56.

Mike Hommey [:glandium]

Assignee

Updated

•

3 years ago

Blocks: 1736459

You need to log in before you can comment on or make changes to this bug.

firefox-91.1.0 fails to compile with rust-1.56

1:52.57 error[E0557]: feature has been removed 1:52.57 --> /var/tmp/portage/www-client/firefox-91.1.0/work/firefox-91.1.0/third_party/rust/packed_simd/src/lib.rs:203:5 1:52.57 | 1:52.57 203 | const_generics, 1:52.57 | ^^^^^^^^^^^^^^ feature has been removed 1:52.57 |

ESR Uplift Approval Request

1:52.57 error[E0557]: feature has been removed
1:52.57 --> /var/tmp/portage/www-client/firefox-91.1.0/work/firefox-91.1.0/third_party/rust/packed_simd/src/lib.rs:203:5
1:52.57 |
1:52.57 203 | const_generics,
1:52.57 | ^^^^^^^^^^^^^^ feature has been removed
1:52.57 |