1736459 - Update builders to rustc 1.56

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, task)

Description

[Mike Hommey [:glandium]]

When it releases (should be oct 21)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1736459 - Update builders to rustc 1.56.

Comment 2

[Arthur K. (he/him)]

Was released today.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47fdc6711870
Update builders to rustc 1.56. r=firefox-build-system-reviewers,andi

Comment 4

[Marian-Vasile Laza]

Backed out changeset 47fdc6711870 (Bug 1736459) for causing build bustages.
Backout link
Push with failures - f
Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb0bd4552c26
Update builders to rustc 1.56. r=firefox-build-system-reviewers,andi

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1736459 - Switch the spidermonkey fuzzing build to clang 13.

It was waiting for rust 1.56. Consequently remove clang 12, since it's
not used anymore.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1548d79706bb
Switch the spidermonkey fuzzing build to clang 13.

Comment 8

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1736459) for causing SM bustage CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=1548d79706bb9405e5279c9ce3ec2fdd322a49e0&selectedTaskRun=ZB_9TXofQWuizZ_yo7KJWw.0

Log: https://treeherder.mozilla.org/logviewer?job_id=355793800&repo=autoland&lineNumber=6162
Also: https://treeherder.mozilla.org/logviewer?job_id=355793058&repo=autoland&lineNumber=2375
xpc failures: https://treeherder.mozilla.org/logviewer?job_id=355796157&repo=autoland&lineNumber=1971

Backout: https://hg.mozilla.org/integration/autoland/rev/2f38fe6c1e984327c52bacf14ab4467a9571139f

Comment 9

[Mike Hommey [:glandium]]

(In reply to Noemi Erli[:noemi_erli] from comment #8)

Log: https://treeherder.mozilla.org/logviewer?job_id=355793800&repo=autoland&lineNumber=6162

Filed https://github.com/rust-lang/rust/issues/90300. As a workaround, we can disable LTO on those fuzzing builds.

Comment 10

[Mike Hommey [:glandium]]

(In reply to Noemi Erli[:noemi_erli] from comment #8)

xpc failures: https://treeherder.mozilla.org/logviewer?job_id=355796157&repo=autoland&lineNumber=1971

This one turned green before the backout: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=H1jD5VjXTW-7jd2pnw93GA.0&searchStr=Windows%2C10%2Cx64%2C2004%2CWebRender%2Copt%2CXpcshell%2Ctests%2Ctest-windows10-64-2004-qr%2Fopt-xpcshell-e10s%2CX1&tochange=2f38fe6c1e984327c52bacf14ab4467a9571139f&fromchange=afcf62ffe91d6118c271380e19492c7e43481cdd

Comment 11

[Mike Hommey [:glandium]]

Attachment: Bug 1736459 - Disable rust lto when enabling sancov.

Comment 12

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #10)

(In reply to Noemi Erli[:noemi_erli] from comment #8)

xpc failures: https://treeherder.mozilla.org/logviewer?job_id=355796157&repo=autoland&lineNumber=1971

This one turned green before the backout: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=H1jD5VjXTW-7jd2pnw93GA.0&searchStr=Windows%2C10%2Cx64%2C2004%2CWebRender%2Copt%2CXpcshell%2Ctests%2Ctest-windows10-64-2004-qr%2Fopt-xpcshell-e10s%2CX1&tochange=2f38fe6c1e984327c52bacf14ab4467a9571139f&fromchange=afcf62ffe91d6118c271380e19492c7e43481cdd

Weirdly enough, this is reproducible with a try of current central+the patches from this bug.

Comment 13

[Mike Hommey [:glandium]]

Attachment: Bug 1736459 - Disable test_crash_backgroundtask_moz_crash.js on Windows.

Comment 14

[Olivier Tilloy]

The firefox snap is built on Ubuntu 20.04, and uses rustup to get the latest rustc stable release. When 1.56.0 was released, builds started to exhibit a regression in audio capture in WebRTC applications. Pinning the rust version to 1.55.0 fixes the problem.

I haven't had a chance to dig deeper yet, but I thought I'd mention it here, in case it's not just the snap that's affected.

Comment 15

[Mike Hommey [:glandium]]

Attachment: Bug 1736459 - Handle null RawHandles in winapi-util.

This works around a regression in rust 1.56's libstd.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59eeaeafdf67
Don't initialize env_logger when stdout/stderr don't exist on Windows. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/2a8f412c4d08
Disable rust lto when enabling sancov. r=truber
https://hg.mozilla.org/integration/autoland/rev/798893f69a02
Disable test_crash_backgroundtask_moz_crash.js on Windows. r=gsvelto
https://hg.mozilla.org/integration/autoland/rev/0b2da7db414c
Update builders to rustc 1.56. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/c934eeb21692
Switch the spidermonkey fuzzing build to clang 13. r=firefox-build-system-reviewers,andi

Comment 17

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/59eeaeafdf67
https://hg.mozilla.org/mozilla-central/rev/2a8f412c4d08
https://hg.mozilla.org/mozilla-central/rev/798893f69a02
https://hg.mozilla.org/mozilla-central/rev/0b2da7db414c
https://hg.mozilla.org/mozilla-central/rev/c934eeb21692

Comment 18

[Norisz Fay [:noriszfay]]

Backed out for causing Windows crashes (Bug 1738034)

Backout link: https://hg.mozilla.org/mozilla-central/rev/71089265de178cef408d0b861f6252fe6d9ace35

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78d10730d088
Handle null RawHandles in winapi-util. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/48e08e929ce7
Disable rust lto when enabling sancov. r=truber
https://hg.mozilla.org/integration/autoland/rev/3c96bab38c95
Disable test_crash_backgroundtask_moz_crash.js on Windows. r=gsvelto
https://hg.mozilla.org/integration/autoland/rev/de36c45ed2a7
Update builders to rustc 1.56. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/3d8df6da990d
Switch the spidermonkey fuzzing build to clang 13. r=firefox-build-system-reviewers,andi

Comment 20

[Mike Hommey [:glandium]]

Attachment: Bug 1736459 - Restore the HandleRef::as_file and as_file_mut methods for geckodriver.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad8ebf7de356
Restore the HandleRef::as_file and as_file_mut methods for geckodriver. r=nika

Comment 22

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/78d10730d088
https://hg.mozilla.org/mozilla-central/rev/48e08e929ce7
https://hg.mozilla.org/mozilla-central/rev/3c96bab38c95
https://hg.mozilla.org/mozilla-central/rev/de36c45ed2a7
https://hg.mozilla.org/mozilla-central/rev/3d8df6da990d
https://hg.mozilla.org/mozilla-central/rev/ad8ebf7de356

Comment 23

[Arthur K. (he/him)]

Does Rust 1.56 for FF95 need to bumped to 1.56.1 to address https://blog.rust-lang.org/2021/11/01/cve-2021-42574.html ?

Comment 24

[Sylvestre Ledru [:Sylvestre]]

Probably not, we have now a linter for this which will break the ci if it happens