Closed Bug 1736459 Opened 3 months ago Closed 3 months ago

Update builders to rustc 1.56

Categories

(Firefox Build System :: Toolchains, task)

task

Tracking

(firefox95 fixed)

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

When it releases (should be oct 21)

Was released today.

Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/47fdc6711870
Update builders to rustc 1.56. r=firefox-build-system-reviewers,andi

Backed out changeset 47fdc6711870 (Bug 1736459) for causing build bustages.
Backout link
Push with failures - f
Failure Log

Flags: needinfo?(mh+mozilla)
Depends on: 1737196
Depends on: 1737197
Flags: needinfo?(mh+mozilla)
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/cb0bd4552c26
Update builders to rustc 1.56. r=firefox-build-system-reviewers,andi

It was waiting for rust 1.56. Consequently remove clang 12, since it's
not used anymore.

Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/1548d79706bb
Switch the spidermonkey fuzzing build to clang 13.

(In reply to Noemi Erli[:noemi_erli] from comment #8)

Log: https://treeherder.mozilla.org/logviewer?job_id=355793800&repo=autoland&lineNumber=6162

Filed https://github.com/rust-lang/rust/issues/90300. As a workaround, we can disable LTO on those fuzzing builds.

Flags: needinfo?(mh+mozilla)

The firefox snap is built on Ubuntu 20.04, and uses rustup to get the latest rustc stable release. When 1.56.0 was released, builds started to exhibit a regression in audio capture in WebRTC applications. Pinning the rust version to 1.55.0 fixes the problem.

I haven't had a chance to dig deeper yet, but I thought I'd mention it here, in case it's not just the snap that's affected.

This works around a regression in rust 1.56's libstd.

Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/59eeaeafdf67
Don't initialize env_logger when stdout/stderr don't exist on Windows. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/2a8f412c4d08
Disable rust lto when enabling sancov. r=truber
https://hg.mozilla.org/integration/autoland/rev/798893f69a02
Disable test_crash_backgroundtask_moz_crash.js on Windows. r=gsvelto
https://hg.mozilla.org/integration/autoland/rev/0b2da7db414c
Update builders to rustc 1.56. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/c934eeb21692
Switch the spidermonkey fuzzing build to clang 13. r=firefox-build-system-reviewers,andi
Status: RESOLVED → REOPENED
Flags: needinfo?(mh+mozilla)
Resolution: FIXED → ---
Target Milestone: 95 Branch → ---
Attachment #9247874 - Attachment description: Bug 1736459 - Don't initialize env_logger when stdout/stderr don't exist on Windows. → Bug 1736459 - Use a dummy logger when stdout/stderr don't exist on Windows.
Attachment #9247874 - Attachment description: Bug 1736459 - Use a dummy logger when stdout/stderr don't exist on Windows. → Bug 1736459 - Handle null RawHandles in winapi-util.
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/78d10730d088
Handle null RawHandles in winapi-util. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/48e08e929ce7
Disable rust lto when enabling sancov. r=truber
https://hg.mozilla.org/integration/autoland/rev/3c96bab38c95
Disable test_crash_backgroundtask_moz_crash.js on Windows. r=gsvelto
https://hg.mozilla.org/integration/autoland/rev/de36c45ed2a7
Update builders to rustc 1.56. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/3d8df6da990d
Switch the spidermonkey fuzzing build to clang 13. r=firefox-build-system-reviewers,andi
Pushed by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad8ebf7de356
Restore the HandleRef::as_file and as_file_mut methods for geckodriver. r=nika
Flags: needinfo?(mh+mozilla)
Regressions: 1736970

Does Rust 1.56 for FF95 need to bumped to 1.56.1 to address https://blog.rust-lang.org/2021/11/01/cve-2021-42574.html ?

Probably not, we have now a linter for this which will break the ci if it happens

You need to log in before you can comment on or make changes to this bug.